Change the openjdk to adoptjdk #5
Conversation
Signed-off-by: Sven Marquardt <[email protected]> geändert: src/main/scala/io/sdkman/changelogs/Migrations.scala geändert: src/main/scala/io/sdkman/changelogs/package.scala
Signed-off-by: Sven Marquardt <[email protected]> geändert: src/main/scala/io/sdkman/changelogs/Migrations.scala
Signed-off-by: Sven Marquardt <[email protected]> geändert: src/main/scala/io/sdkman/changelogs/Migrations.scala
Signed-off-by: Sven Marquardt <[email protected]> geändert: src/main/scala/io/sdkman/changelogs/Migrations.scala
Signed-off-by: Sven Marquardt <[email protected]> geändert: src/main/scala/io/sdkman/changelogs/Migrations.scala
|
Not certain I agree. AdoptOpenJDK are actually the official openjdk builds now, and the ones that you refer to are merely what debian/fedora etc package themselves. I'd prefer rolling with openjdk, because this is precisely what it is in it's purest form. |
|
ok so i was confused because here http://jdk.java.net/10/ java 10 is build for all major platforms but in adoptopenjdk https://adoptopenjdk.net/releases.html?variant=openjdk10 only linux and mac is released. Also it is not the final build. |
There was a problem hiding this comment.
I think Martin Verburg (@ kariana on Twitter) and some of the IBM guys are heading up this initiative and are very serious about distributing a free open source JDK distribution, which is Adopt. The ones hosted on java.net are actually Oracle JDKs without the proprietary stuff. It's still an Oracle JDK at the end of the day.
| insertVersions( | ||
| CandidateVersion("java", "10-openjdk", Some("WINDOWS_64"), "https://download.java.net/java/GA/jdk10/10/binaries/openjdk-10_windows-x64_bin.tar.gz"), | ||
| CandidateVersion("java", "10-openjdk", Some("MAC_OSX"), "https://download.java.net/java/GA/jdk10/10/binaries/openjdk-10_osx-x64_bin.tar.gz"), | ||
| CandidateVersion("java", "10-openjdk", Some("LINUX_64"), "https://download.java.net/java/GA/jdk10/10/binaries/openjdk-10_linux-x64_bin.tar.gz")) |
There was a problem hiding this comment.
These are actually Oracle's openjdk distributions. I think adopt are considered more official by now.
There was a problem hiding this comment.
This wasn't intended for this PR. I pushed to the wrong branch here sorry for that. I wanted to make a new PR for this one.
|
|
||
| @ChangeSet(order = "008", id = "008-change_openjdk_to_adoptopenjdk", author = "MaSven") | ||
| def migrate008(implicit db: MongoDatabase) = { | ||
| updateVersion("9u181-openjdk", "9u181-adoptopenjdk") |
There was a problem hiding this comment.
This name is too verbose, and takes up too much real estate in the list view. I think we should stick with openjdk for now.
| package io.sdkman.changelogs | ||
|
|
||
| import com.github.mongobee.changeset.{ChangeLog, ChangeSet} | ||
| import com.github.mongobee.changeset.{ ChangeLog, ChangeSet } |
There was a problem hiding this comment.
Not related to the PR, and not the standard scala code style.
There was a problem hiding this comment.
Sorry not a scala dev and just downloaded the scala ide for the pull requests. Do you have some form of setting for the scala ide so i have the right formatting?
| candidate: String, | ||
| version: String, | ||
| platform: Option[String], | ||
| url: String) |
There was a problem hiding this comment.
Reformatting not a part of this PR. Also, once again not standard scala code style.
| db.getCollection("candidates").findOneAndUpdate(Filters.eq("candidate", candidate), Updates.set("default", version)) | ||
|
|
||
| def updateVersion(version: String, newVersion: String)(implicit db: MongoDatabase): Unit = { | ||
| db.getCollection("versions").updateMany(Filters.eq("version", version), Updates.set("version", newVersion)) |
There was a problem hiding this comment.
updateMany could potentially be dangerous as version could be very ambiguous. I like the idea of adding this helper function though...
There was a problem hiding this comment.
Ok so i think a better way would be to find them one by one and after that update the version?
|
@MaSven It's late here now, let me sleep on this a bit. I think adoptjdk does sound kinda cool ;-) |
|
yes and it is shorter. Makes less typing. |
|
After the Twitter poll on Friday it is conclusive that everyone wants the openjdk from java.net. This will become our official openjdk distribution of choice and all others will be removed soon (no point in hosting multiple openjdk distros as they all contain the same). As a result of this, I'm closing this PR for now. Feel free to raise a new PR for the java.net openjdk that you had in this PR. |
3 participants
I think people will get confused with the openjdk suffic since openjdk releases it's own builds. So i changed the suffix for the adoptopenjdk to -adoptopenjdk. Also to make clear that this are not the openjdk builds.