Add Jeka candidate #718
Merged
Add Jeka candidate #718
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marc0der
reviewed
Jan 4, 2025
marc0der
requested changes
Jan 4, 2025
Member
marc0der
left a comment
marc0der
left a comment
There was a problem hiding this comment.
The name and description are used on our website and when you run sdk list so we need a bit more verbosity and uniformity.
marc0der
reviewed
Jan 4, 2025
Co-authored-by: Marco Vermeulen <[email protected]>
Co-authored-by: Marco Vermeulen <[email protected]>
Contributor
Author
|
I’ve fixed the website URL as well. The description looks good to me. I think we can move forward. Thank you! |
Member
|
Apologies, I totally missed your changes back in December and forgot about this PR. Would you like me to merge that now @djeang? |
marc0der
approved these changes
Mar 15, 2025
Contributor
Author
|
Hi Marc, sorry for this delay, too. I was focused on improving the product itself. I'm now ready to follow up the SdkMan onboarding. Can you merge the request please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.