Skip to content

Conversation

@r0b0
Copy link

@r0b0 r0b0 commented Mar 28, 2018

Please add Apache CXF sdk

Copy link
Member

@marc0der marc0der left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just needs a Candidate now.

@ChangeLog(order = "005")
class CxfMigrations {

@ChangeSet(order = "001", id = "001_add_cxf_3_2_4", author = "marc0der")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The author would probably need to be r0b0 in this case ;-)

@ChangeSet(order = "001", id = "001_add_cxf_3_2_4", author = "marc0der")
def migration001(implicit db: MongoDatabase) = {
insertVersion(Version("cxf", "3.2.4", Some("UNIVERSAL"), "http://www.apache.org/dyn/closer.lua/cxf/3.2.4/apache-cxf-3.2.4.zip"))
setCandidateDefault("cxf", "3.2.4")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You would also need to add the new Candidate prior to setting the candidate default. See the insertCandidate(c: Candidate) function for this. The README.md should also have a few more tips about what to populate the Candidate with.

Copy link
Member

@marc0der marc0der left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thanks!

@marc0der marc0der merged commit 2aadaa4 into sdkman:master Apr 3, 2018
@marc0der
Copy link
Member

marc0der commented Apr 3, 2018

Thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants