Skip to content

Set X-Powered-By header.#112

Merged
joanniclaborde merged 1 commit into
masterfrom
set-x-powered-by
Jun 30, 2014
Merged

Set X-Powered-By header.#112
joanniclaborde merged 1 commit into
masterfrom
set-x-powered-by

Conversation

@joanniclaborde
Copy link
Copy Markdown
Contributor

Sets the X-Powered-By header to Solidus/{version}, for example Solidus/0.1.7.

@jameslovejoy
Copy link
Copy Markdown

I like this feature 🌟

However, if solidus returns a 404, the header still shows Express:

$ curl -i http://lvh.me:8080/foo
HTTP/1.1 404 Not Found
X-Powered-By: Express
Vary: Accept-Encoding
Content-Type: text/html; charset=utf-8
Content-Length: 13
Date: Thu, 26 Jun 2014 18:50:14 GMT
Connection: keep-alive

404 Not Found

@jameslovejoy
Copy link
Copy Markdown

Maybe this should be a separate feature request, but I would find it helpful to see the version number in the console when developing locally. Something like:

[SOLIDUS] Server 0.1.7 running on port 8080

@joanniclaborde
Copy link
Copy Markdown
Contributor Author

Nice catch! I fixed both issues.

@jameslovejoy
Copy link
Copy Markdown

👍 👍

joanniclaborde added a commit that referenced this pull request Jun 30, 2014
@joanniclaborde joanniclaborde merged commit 6fdf042 into master Jun 30, 2014
@joanniclaborde joanniclaborde deleted the set-x-powered-by branch June 30, 2014 13:43
@pushred pushred added this to the 0.2.0 milestone Aug 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants