-
-
Notifications
You must be signed in to change notification settings - Fork 246
fix(snippets): rounded images #1018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fixed Rounded Images snippet artists image border radius in Spotify version 1.2.72
WalkthroughExpanded the CSS selector list in the "Rounded Images" snippet within resources/snippets.json to include .lKuMkIKSZanMIK6aQWfx for applying border-radius: 6px. No other values or selectors were changed. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Pre-merge checks (3 passed)✅ Passed checks (3 passed)
Poem
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. ✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
resources/snippets.json (2)
23-23: Harden against future class hash changesSpotify’s obfuscated class names churn frequently. Consider adding a more resilient fallback alongside the new hash (e.g., a stable ancestor + descendant
imgor an attribute/data-testid selector if present) to avoid re-breaking on the next update. Keep specificity ≤ current group (use:where()if needed) to avoid unintended overrides.
23-23: Deduplicate overlapping rules for home shortcuts image
.view-homeShortcutsGrid-imageis set toborder-radius: 4pxin “Collapsed Cover Art Image” and again later with!important. Consolidate to a single place (prefer the!importantblock if required) to reduce maintenance churn.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
resources/snippets.json(1 hunks)
🔇 Additional comments (1)
resources/snippets.json (1)
23-23: LGTM: added selector fixes rounded artist images on 1.2.72Adding
.lKuMkIKSZanMIK6aQWfxto the 6px group is consistent with the snippet’s intent and should cover the new DOM shape in 1.2.72 without affecting other targets.
Fixed Rounded Images snippet artists image border radius in Spotify version 1.2.72
Summary by CodeRabbit