Skip to content

Conversation

@Climax12
Copy link
Contributor

@Climax12 Climax12 commented Sep 11, 2025

Fixed Rounded Images snippet artists image border radius in Spotify version 1.2.72

Summary by CodeRabbit

  • Style
    • Expanded rounded-corner styling to additional images for consistent 6px rounding across the app.
    • Circular images remain unchanged at 50% radius.
    • Improves visual consistency in cards, lists, and media sections; existing layouts unaffected.
    • Addresses previously sharp-cornered thumbnails in some views without altering behavior or settings.

Fixed Rounded Images snippet artists image border radius in Spotify version 1.2.72
@Climax12 Climax12 requested a review from a team as a code owner September 11, 2025 16:14
@Climax12 Climax12 requested review from theRealPadster and removed request for a team September 11, 2025 16:14
@coderabbitai
Copy link

coderabbitai bot commented Sep 11, 2025

Walkthrough

Expanded the CSS selector list in the "Rounded Images" snippet within resources/snippets.json to include .lKuMkIKSZanMIK6aQWfx for applying border-radius: 6px. No other values or selectors were changed.

Changes

Cohort / File(s) Summary of Edits
CSS selector update
resources/snippets.json
Added .lKuMkIKSZanMIK6aQWfx to the selector group that applies border-radius: 6px in the "Rounded Images" snippet; no other modifications.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Pre-merge checks (3 passed)

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title "fix(snippets): rounded images" accurately reflects the main change—fixing image rounding in the snippets CSS—and is concise and written in conventional commit style. It directly relates to the changeset which extends the selectors applying border-radius to snippet images. While it could be slightly more specific (for example "artist image border radius"), the current title is clear enough for a quick scan.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.

Poem

I nudge the corners, soft and neat,
A rounded edge for images sweet.
One more class joins the cozy ring—
CSS whispers, “smooth everything.”
Hop-hop, I tweak with gentle art,
Curves all around, a bunny’s heart.

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.

✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
resources/snippets.json (2)

23-23: Harden against future class hash changes

Spotify’s obfuscated class names churn frequently. Consider adding a more resilient fallback alongside the new hash (e.g., a stable ancestor + descendant img or an attribute/data-testid selector if present) to avoid re-breaking on the next update. Keep specificity ≤ current group (use :where() if needed) to avoid unintended overrides.


23-23: Deduplicate overlapping rules for home shortcuts image

.view-homeShortcutsGrid-image is set to border-radius: 4px in “Collapsed Cover Art Image” and again later with !important. Consolidate to a single place (prefer the !important block if required) to reduce maintenance churn.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 27aded1 and e41618c.

📒 Files selected for processing (1)
  • resources/snippets.json (1 hunks)
🔇 Additional comments (1)
resources/snippets.json (1)

23-23: LGTM: added selector fixes rounded artist images on 1.2.72

Adding .lKuMkIKSZanMIK6aQWfx to the 6px group is consistent with the snippet’s intent and should cover the new DOM shape in 1.2.72 without affecting other targets.

@kyrie25 kyrie25 merged commit d1747b8 into spicetify:main Sep 12, 2025
7 checks passed
@Climax12 Climax12 deleted the upd branch September 12, 2025 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants