-
-
Notifications
You must be signed in to change notification settings - Fork 247
adding custom Background #353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Purple Darth Vadder Background
|
Why don't adding an option into the Marketplace options with a toggle to enable/disable the option itself, and a second one to let or change the default URL you purpose ? |
Bit confused on what you mean by the first part |
In simple therms: why just don't add an enable/disable option to apply a custom background img ? |
That would not be possible using pure CSS/as a snippet, which is what this PR tries to do. Plus that is not the purpose of Marketplace, if you wish to do so feel free to make an extension and publish it on Marketplace. |
|
I had an idea to make this viable, let snippets use string and int variables and expand their features a little to allow users to input these |
Lol if so just let them use CSS body variables. You can set them using snippets already. Using custom background via this snippet thus is also possible if this were to access a variable and the user define that variable value in another snippet. |
|
Do we let users edit the built-in snippets? Then they could just change the image url |
Pretty sure we do, but I think basically wrapping css variables in a ui is probably more useable since a lot of users wouldn't want to edit the text |
|
The Spicetify Galaxy theme lets you use custom backgrounds for Home Screen(This is applied to all other pages other than the forth mentioned one) and Playlist Pages. You can maybe request him to add an option for the marketplace. He's quick with the replies and added a feature I requested in a day or two. |
|
We could also just add it as an option in the marketplace settings, and use a variable. e.g. in the settings modal, have a text entry for adding an image url, and that's saved as |
Purple Darth Vadder Background