Skip to content

Conversation

@byQuexo
Copy link

@byQuexo byQuexo commented Oct 29, 2022

Purple Darth Vadder Background

Purple Darth Vadder Background
@byQuexo byQuexo requested a review from a team as a code owner October 29, 2022 21:17
@byQuexo byQuexo requested review from theRealPadster and removed request for a team October 29, 2022 21:17
@xerta555
Copy link
Contributor

xerta555 commented Nov 4, 2022

Why don't adding an option into the Marketplace options with a toggle to enable/disable the option itself, and a second one to let or change the default URL you purpose ?
It would be more flexible..

@CharlieS1103
Copy link
Member

Why don't adding an option into the Marketplace options with a toggle to enable/disable the option itself, and a second one to let or change the default URL you purpose ?

It would be more flexible..

Bit confused on what you mean by the first part

@xerta555
Copy link
Contributor

xerta555 commented Nov 4, 2022

Why don't adding an option into the Marketplace options with a toggle to enable/disable the option itself, and a second one to let or change the default URL you purpose ?
It would be more flexible..

Bit confused on what you mean by the first part

In simple therms: why just don't add an enable/disable option to apply a custom background img ?
A first option to toggle the function and a second one to apply a specific one with an URL.

@kyrie25
Copy link
Member

kyrie25 commented Nov 4, 2022

Why don't adding an option into the Marketplace options with a toggle to enable/disable the option itself, and a second one to let or change the default URL you purpose ?

It would be more flexible..

Bit confused on what you mean by the first part

In simple therms: why just don't add an enable/disable option to apply a custom background img ?

A first option to toggle the function and a second one to apply a specific one with an URL.

That would not be possible using pure CSS/as a snippet, which is what this PR tries to do.

Plus that is not the purpose of Marketplace, if you wish to do so feel free to make an extension and publish it on Marketplace.

@CharlieS1103
Copy link
Member

I had an idea to make this viable, let snippets use string and int variables and expand their features a little to allow users to input these

@kyrie25
Copy link
Member

kyrie25 commented Jan 1, 2023

I had an idea to make this viable, let snippets use string and int variables and expand their features a little to allow users to input these

Lol if so just let them use CSS body variables. You can set them using snippets already.

Using custom background via this snippet thus is also possible if this were to access a variable and the user define that variable value in another snippet.

@theRealPadster
Copy link
Member

Do we let users edit the built-in snippets? Then they could just change the image url

@CharlieS1103
Copy link
Member

Do we let users edit the built-in snippets? Then they could just change the image url

Pretty sure we do, but I think basically wrapping css variables in a ui is probably more useable since a lot of users wouldn't want to edit the text

@Satanarious
Copy link

The Spicetify Galaxy theme lets you use custom backgrounds for Home Screen(This is applied to all other pages other than the forth mentioned one) and Playlist Pages. You can maybe request him to add an option for the marketplace. He's quick with the replies and added a feature I requested in a day or two.

@theRealPadster
Copy link
Member

We could also just add it as an option in the marketplace settings, and use a variable.

e.g. in the settings modal, have a text entry for adding an image url, and that's saved as --marketplace-body-background. Then when that's changed, we set it on body. Or is it possible to have CSS be conditional if a variable exists or not?

@byQuexo byQuexo closed this Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants