Skip to content

feat(snippets): no music provider#494

Closed
Aimarekin wants to merge 0 commit intospicetify:mainfrom
Aimarekin:main
Closed

feat(snippets): no music provider#494
Aimarekin wants to merge 0 commit intospicetify:mainfrom
Aimarekin:main

Conversation

@Aimarekin
Copy link
Copy Markdown

Hides the music provider from the lyrics view

@Aimarekin Aimarekin requested a review from a team as a code owner May 22, 2023 01:23
@Aimarekin Aimarekin requested review from CharlieS1103 and removed request for a team May 22, 2023 01:23
Copy link
Copy Markdown
Member

@kyrie25 kyrie25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

goofy preview image lol

@kyrie25 kyrie25 changed the title feat(snippets): Add "No Music Provider" snippets feat(snippets): add "No Music Provider" May 22, 2023
@kyrie25
Copy link
Copy Markdown
Member

kyrie25 commented May 22, 2023

Resolve Lint issue.

@theRealPadster
Copy link
Copy Markdown
Member

Maybe do an X or line through the lyrics provider in the preview image. I think that's what most of the others do. It also might be hard to read the text when it's in the app

Copy link
Copy Markdown
Member

@kyrie25 kyrie25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Address Padster's suggestion & resolve conflict

@rxri rxri changed the title feat(snippets): add "No Music Provider" feat(snippets): no music provider Jul 13, 2023
@Aimarekin Aimarekin closed this Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants