增加博客类型，xss攻击拦截 #101
Closed
增加博客类型，xss攻击拦截 #101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
SQL的修改可以提交到document文档里面的SQL语句当中噢，直接在创建表的SQL语句上修改即可 |
Owner
|
当前新增的功能应该提交到dev分支，我根据你提的issue单独开了一个dev分支噢
分支的名称为 dev_blog_#100，你当前的代码应该合并到这个分支上。 |
stick-i
requested changes
Oct 28, 2022
blog-service/blog-server/src/main/java/cn/sticki/blog/pojo/bo/BlogSaveBO.java
Show resolved
Hide resolved
| return new RestResult<>(402, "参数异常", null, false); | ||
| String message = "参数异常"; | ||
| if (e instanceof IllegalArgumentException) { | ||
| message = "参数异常:" + e.getMessage(); |
Owner
There was a problem hiding this comment.
这样校验是否会导致某些非人为控制抛出IllegalArgumentException的地方，会将异常信息返回到前端？
Author
There was a problem hiding this comment.
如果有非我们显示调用抛出的IllegalArgumentException异常，说明是代码bug,需要修复，现在这个单独处理，是因为使用了spring的Assert 断言类，message描述了异常原因，需要主动抛给前端，进行友好提示。
也可以考虑自己创建断言类，自定义异常，不用或继承IllegalArgumentException
common/common-web/src/main/java/cn/sticki/common/web/filter/XssFilter.java
Show resolved
Hide resolved
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
需要执行sql脚本
alter table blog.blog
add create_type int(1) null comment '博客创作类型：1. 原创; 2. 转载';
@stick-i