Skip to content

Conversation

@grimrose
Copy link
Member

@grimrose grimrose commented Jul 4, 2017

No description provided.

Copy link
Member

@twada twada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.travis.yml 以外は LGTM です!

- "4"
- "5"
- "6"
- "7"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

サポートの切れた Node5 を外し、代わりに Node8 を入れましょう

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

airbnb/enzymeに参考となるcommitがあったのでやってみます

"lint": "jshint lib test",
"test": "npm run lint && mocha --require intelli-espower-loader",
"lint": "eslint 'lib/**' 'test/**'",
"pretest": "npm run lint",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pretest いいですね! 👍

remove deprecated version
append latest node version
@twada
Copy link
Member

twada commented Jul 6, 2017

LGTM 👍

@grimrose
Copy link
Member Author

grimrose commented Jul 6, 2017

ありがとうございました! 👍

@grimrose grimrose merged commit 84e9d33 into master Jul 6, 2017
@grimrose grimrose deleted the update-dependencies branch July 6, 2017 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants