accept fusionfeed jwts #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
ccbrown
force-pushed
the
07-06-accept_fusionfeed_jwts
branch
from
bdf4b73 to
beeb9bd
Compare
ashukur
reviewed
Jul 16, 2024
| const url = publicRuntimeConfig.fusionFeedUrl + '/v2/graphql'; | ||
| const subscriptionUrl = publicRuntimeConfig.fusionFeedUrl + '/v2/graphql-ws'; | ||
| const token = cookie.get('fftoken'); | ||
| const tokenType = token?.includes('.') ? 'Bearer' : 'token'; |
There was a problem hiding this comment.
assuming checking for "." here works because we are joining two strings with that as the separator ?
Contributor
Author
There was a problem hiding this comment.
JWTs are always in HEADER.PAYLOAD.SIGNATURE format. And our API keys never have dots. So if it has at least one dot, it's a JWT.
ashukur
approved these changes
Jul 16, 2024
ashukur
left a comment
ashukur
left a comment
There was a problem hiding this comment.
LGTM assuming that the "." is a reliable way to say something is a Bearer token
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the docs site able to accept JWTs in addition to static API keys.