Small performance improvement in l2_error calculation#18
Open
Nirei wants to merge 1 commit intotorrvision:mainfrom
Open
Small performance improvement in l2_error calculation#18Nirei wants to merge 1 commit intotorrvision:mainfrom
l2_error calculation#18Nirei wants to merge 1 commit intotorrvision:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When calculating the L2 error for ECE, the square root of the sum is taken repeatedly inside the loop. This result is unused in all but the last iteration so a minimal performance gain may be obtained by taking this calculation out of the loop and doing it only once before returning.