Added Support for CompileException to get notified when an error occures#3
Merged
trung merged 1 commit intotrung:masterfrom Sep 24, 2017
PKeidel:master
Merged
Added Support for CompileException to get notified when an error occures#3trung merged 1 commit intotrung:masterfrom PKeidel:master
trung merged 1 commit intotrung:masterfrom
PKeidel:master
Conversation
trung
requested changes
Sep 23, 2017
Owner
trung
left a comment
trung
left a comment
There was a problem hiding this comment.
Thanks for the contribution. And sorry for getting back super late.
Can you add a test case for this change?
Owner
|
There's another PR doing similar #5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I just added a CompileException and a DiagnosticCollector. If compilation fails the Exception is thrown.