Studio: Fix clipped model selector text descenders - #5210
Merged
danielhanchen merged 7 commits intoApr 29, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Imagineer99
marked this pull request as ready for review
April 28, 2026 14:58
* fix: allow image-only chat messages * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * test: deduplicate empty content validation coverage --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Replace `leading-none` with `leading-tight` on the parent div wrapping `displayTitle` and the "Studio" label inside `SidebarMenuButton`. The child spans use `truncate` (overflow: hidden), so `line-height: 1` clipped descenders (g, p, q, y, j) on user names. Same root cause and fix as the model selector trigger.
danielhanchen
added
auto-approved
Member
|
Auto-review verdict: Approved PR #5210 swaps Tailwind Reason: Real descender-clipping bug fixed at the original location and at one parallel location found during review; all reviewers across 3 iterations approve, no remaining bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a visual issue where model names containing descenders, such as
g,p, orq, could appear clipped at the bottom in the model selector trigger.The label previously used
leading-nonetogether withtruncate, which appliesoverflow: hidden. That made the text box tight enough for some font descenders to be clipped. This changes the label toleading-tight, keeping truncation behavior while giving the glyphs enough vertical room.Before:
After:
