Minor syntactic changes#8
Merged
Leonidas-from-XIV merged 3 commits intoverbosemode:masterfrom Oct 20, 2016
Merged
Conversation
Collaborator
Leonidas-from-XIV
left a comment
Leonidas-from-XIV
left a comment
There was a problem hiding this comment.
Overall I think it does improve readability, thanks!
(Also, I am new to the new GitHub review thing, hope I didn't mess up too badly)
src/syslog_message.ml
Outdated
| let data = String.with_range ~first:(pri_endmarker + 1) ~len:(l - pri_endmarker -1) s in | ||
| Some (facility, severity, data) | ||
| let facility = facility_of_int @@ priority_value / 8 in | ||
| let severity = severity_of_int @@ priority_value mod 8 in |
Collaborator
There was a problem hiding this comment.
Could also be turned into and while at it.
src/syslog_message.ml
Outdated
| match String.length s with | ||
| | l when l > 1 -> | ||
| (match String.find (fun x -> x = ' ') s with | ||
| begin match String.find (fun x -> x = ' ') s with |
Collaborator
There was a problem hiding this comment.
Not a big fan of this particular change as it makes it tougher for editors to match begin/end together than (/).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.