-
Notifications
You must be signed in to change notification settings - Fork 2
Add dataset generate command to CLI #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Add new dataset subcommand with generate operation - Support all arguments from DatasetGenerationRequest model - Add input validation for url_type and max_samples - Implement friendly output formatting for dataset generation results Co-Authored-By: Sudeep Pillai <[email protected]>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
⚙️ Control Options:
|
Co-Authored-By: Sudeep Pillai <[email protected]>
Co-Authored-By: Sudeep Pillai <[email protected]>
vlmrun/cli/_cli/dataset/dataset.py
Outdated
| This command allows you to generate datasets from YouTube playlists or videos. | ||
| The generated dataset will be saved according to the specified format and parameters. | ||
| """ | ||
| client = get_context_client(ctx) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use client = ctx.obj?
vlmrun/cli/utils.py
Outdated
| import typer | ||
| from vlmrun.client import Client | ||
|
|
||
| def get_context_client(ctx: typer.Context) -> Client: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is unnecessary
Co-Authored-By: Sudeep Pillai <[email protected]>
|
I've addressed the review comments:
All CI checks are passing. Please let me know if you'd like any further changes! |
Add dataset generate command to CLI
This PR adds a new
datasetsubcommand to the vlmrun CLI with agenerateoperation that calls the/v1/dataset/generateendpoint. The command supports generating datasets from YouTube playlists and videos with all the parameters supported by the API.Changes
datasetsubcommand withgenerateoperationUsage Example
Testing
The command implementation includes:
Link to Devin run: https://app.devin.ai/sessions/24a085b8c2a64b80ba60775b4ee5c28a