Add dataset create command and dataset resource #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add dataset create CLI command for creating datasets from image directories - Add Dataset resource class with create and get methods - Add DatasetResponse type for dataset operations - Add utility functions for archive creation and image file listing - Add tests for dataset operations - Update mock client to support dataset operations Co-Authored-By: Sudeep Pillai <[email protected]>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
⚙️ Control Options:
|
spillai
reviewed
Jan 16, 2025
| """ | ||
| client = ctx.obj | ||
|
|
||
| # Verify directory contains images |
Contributor
There was a problem hiding this comment.
if not Path(directory).is_dir():
typer.echo("...")
typer.Exit(1)
| client = ctx.obj | ||
|
|
||
| # Verify directory contains images | ||
| image_files = list_image_files(directory) |
Contributor
There was a problem hiding this comment.
Avoid having to call another function, and inline the logic directly here.
|
|
||
|
|
||
| @retry(wait=wait_fixed(10), stop=stop_after_attempt(3), reraise=True) | ||
| def create_archive(directory: Union[str, Path]) -> str: |
Contributor
There was a problem hiding this comment.
Use create_archive(directory: Path) -> Path
| Raises: | ||
| ValueError: If directory does not exist | ||
| """ | ||
| if isinstance(directory, str): |
Contributor
There was a problem hiding this comment.
Avoid this, since directory is assumed to be Path type
|
|
||
| # Create archive in temp directory | ||
| temp_dir = tempfile.gettempdir() | ||
| archive_path = os.path.join(temp_dir, f"dataset_{int(time.time())}.tar.gz") |
Contributor
There was a problem hiding this comment.
Use Path(temp_dir) / f"dataset_..."
spillai
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add dataset create command and dataset resource
This PR adds a new
vlmrun dataset createcommand that allows users to create datasets from directories of images. The command creates a tar.gz archive from the image directory, uploads it viaclient.upload_file, and creates a dataset using the uploaded file.Changes
Testing
Implementation Details
The implementation follows the existing patterns in the codebase:
Link to Devin run: https://app.devin.ai/sessions/eb7f1b55162b4e5290253e45cb13ad86