feat(cli): add config management via ~/.vlmrun/config.toml #57
+226
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaushikb11
changed the title
spillai
reviewed
Feb 12, 2025
vlmrun/cli/_cli/config.py
Outdated
| CONFIG_FILE = Path.home() / ".vlmrun" / "config.toml" | ||
|
|
||
|
|
||
| def get_config() -> dict: |
Contributor
There was a problem hiding this comment.
Can we load this into a pydantic dataclass? That way it'll also do type validation on load.
vlmrun/cli/_cli/config.py
Outdated
| return | ||
|
|
||
| display_config = config.copy() | ||
| if "api_key" in display_config: |
Contributor
There was a problem hiding this comment.
Would be good to load the config as a pydantic dataclass, so that you have attrs like display_config.api_key etc.
| ), | ||
| base_url: Optional[str] = typer.Option( | ||
| DEFAULT_BASE_URL, | ||
| None, |
Contributor
Author
There was a problem hiding this comment.
Because the priority goes like this.
base url passed through the cli command >> base url defined through env variable >> base url fetched from saved config >> default base url.
Contributor
Author
There was a problem hiding this comment.
If we set it as None, it will override the base url stored in local config.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Fixes #56
Add support for persistent configuration:
vlmrun config showto display current settingsvlmrun config set --api-key/--base-urlto update valuesvlmrun config unset --api-key/--base-urlto remove values