feat: Migrate image and video utilities from vlm-tools #7
+189
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
⚙️ Control Options:
|
spillai
reviewed
Jan 7, 2025
vlmrun/common/__init__.py
Outdated
|
|
||
| from .image import encode_image, download_image | ||
|
|
||
| __all__ = ["encode_image", "download_image"] |
Contributor
There was a problem hiding this comment.
Remove the init file and make users import image utilities via from vlmrun.common.image import encode_image
spillai
reviewed
Jan 7, 2025
Contributor
There was a problem hiding this comment.
Resolve the requirements conflicts and rebase on main.
- Add encode_image and download_image functions - Add VideoItertools for CLIP-based frame sampling - Add comprehensive tests and documentation - Update dependencies and README Co-Authored-By: Sudeep Pillai <[email protected]>
- Move CLIP import inside try block - Make VideoItertools import optional in __init__.py - Allow image utilities to work without torch dependencies Co-Authored-By: Sudeep Pillai <[email protected]>
Co-Authored-By: Sudeep Pillai <[email protected]>
- Fix frame_generator fixture to use proper iterator pattern - Add hasattr check in VideoItertools.__del__ for safer cleanup Co-Authored-By: Sudeep Pillai <[email protected]>
Co-Authored-By: Sudeep Pillai <[email protected]>
…paths - Remove vlmrun/common/__init__.py to enforce explicit imports - Update test_image.py to import directly from image module - Update README.md examples to use direct imports This change improves code clarity by making imports more explicit. Co-Authored-By: Sudeep Pillai <[email protected]>
devin-ai-integration
bot
force-pushed
the
devin/1736270073-migrate-utilities
branch
from
5fffcf9 to
86e5f08
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate Image and Video Utilities from vlm-tools
This PR migrates utility methods for image, video, and other tools from vlm-tools to vlmrun-python-sdk, specifically into the vlmrun/common directory.
Changes
Testing
Link to Devin run: https://app.devin.ai/sessions/6ee804e6261142bb9b1fd0f7c5299a8d
Instructions from user: