feat(viz): Add visualization module for VLM Run results #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spillai
reviewed
Mar 6, 2025
| @@ -1,5 +1,8 @@ | |||
| cachetools | |||
| IPython | |||
Contributor
There was a problem hiding this comment.
I wouldn't add IPython as a core dependency unless we need it.
| return img | ||
|
|
||
|
|
||
| def render_image(image: ImageType, width: Optional[int] = None) -> str: |
Contributor
There was a problem hiding this comment.
Let's move this into vlmrun.common.jupyter.format_image_html
| } | ||
|
|
||
|
|
||
| def format_json_html(data: Dict[str, Any], indent: int = 2) -> str: |
Contributor
There was a problem hiding this comment.
Move to vlmrun.common.jupyter.format_json_html
| return f'<pre style="margin: 0; white-space: pre-wrap;">{json_str}</pre>' | ||
|
|
||
|
|
||
| def show_results( |
Contributor
There was a problem hiding this comment.
Move to vlmrun/common/jupyter/
| raise ValueError("image_width must be a positive integer") | ||
|
|
||
|
|
||
| def xywh_to_xyxy(box: XYWHBox) -> BoundingBox: |
Contributor
There was a problem hiding this comment.
Would prefer if we have a BoundingBox class and have classmethods for these to_xyxy, to_xywh etc.
| return (x, y, x + w, y + h) | ||
|
|
||
|
|
||
| def extract_bbox(value: Union[Dict, List]) -> Optional[BoundingBox]: |
| return None | ||
|
|
||
|
|
||
| def get_boxes_from_response(response: Union[Dict, Any]) -> List[Dict[str, BoundingBox]]: |
Contributor
There was a problem hiding this comment.
Don't we want the attributes casted into BoundingBox instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Add comprehensive visualization module for displaying VLM Run results with images:
Example usage: