Add video utilities #8
Merged
+508
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
⚙️ Control Options:
|
Contributor
|
Rebase on main, and make sure the tests pass. Use a valid test video url (https://github.com/autonomi-ai/nos/blob/main/nos/test/test_data/test.mp4) to make sure the tests pass on the VideoReader. |
- Port VideoReader and VideoWriter from nos repository - Add comprehensive test suite - Support OpenCV-based video operations - Add proper error handling and type safety Co-Authored-By: Sudeep Pillai <[email protected]>
Co-Authored-By: Sudeep Pillai <[email protected]>
devin-ai-integration
bot
force-pushed
the
devin/1736270378-port-video-utilities
branch
from
256913a to
bf50061
Compare
spillai
reviewed
Jan 7, 2025
tests/common/test_video.py
Outdated
|
|
||
|
|
||
| @pytest.fixture | ||
| def sample_video(tmp_path) -> Path: |
Contributor
There was a problem hiding this comment.
Remove this, and use test.mp4 instead as sample_video
Co-Authored-By: Sudeep Pillai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Video Utilities for vlmrun-python-sdk
This PR adds video utilities ported from the nos repository, including:
Changes
Testing
Notes
Link to Devin run: https://app.devin.ai/sessions/5ed7213b9cc9419587a3c59a2158e067