use store.loadData rather than store.load#3
Merged
wilk merged 1 commit intowilk:masterfrom Jan 19, 2014
Merged
Conversation
wilk
added a commit
that referenced
this pull request
Jan 19, 2014
use store.loadData rather than store.load
Owner
|
Thank you for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Wilk,
I've finally got back to looking at using WebSocket in my project.
I found a problem when the server pushes an updated record to the store.
You are using store.load which triggers the proxy to do a fresh read rather than use the data that has been pushed. I changed this to store.loadData which, for me at least, has the desired affect. The pushed data just gets added to the store.
There was a 2nd problem here in that loadData doesn't seem to fire the load event, even though the docs says it does, so I just added this to my fix.
Let me know if you think I'm doing something wrong.
AlanE