Skip to content

use store.loadData rather than store.load#3

Merged
wilk merged 1 commit intowilk:masterfrom
kagesys:store.load
Jan 19, 2014
Merged

use store.loadData rather than store.load#3
wilk merged 1 commit intowilk:masterfrom
kagesys:store.load

Conversation

@kagesys
Copy link
Copy Markdown
Contributor

@kagesys kagesys commented Jan 14, 2014

Hi Wilk,

I've finally got back to looking at using WebSocket in my project.
I found a problem when the server pushes an updated record to the store.
You are using store.load which triggers the proxy to do a fresh read rather than use the data that has been pushed. I changed this to store.loadData which, for me at least, has the desired affect. The pushed data just gets added to the store.

There was a 2nd problem here in that loadData doesn't seem to fire the load event, even though the docs says it does, so I just added this to my fix.

Let me know if you think I'm doing something wrong.

AlanE

wilk added a commit that referenced this pull request Jan 19, 2014
use store.loadData rather than store.load
@wilk wilk merged commit fac824b into wilk:master Jan 19, 2014
@wilk
Copy link
Copy Markdown
Owner

wilk commented Jan 19, 2014

Thank you for your contribution!
Just one thing for future pull requests: keep the same coding style, like spaces between function calls and their arguments (e.g.: store.loadData (...); instead of store.loadData(...)), and so on ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants