Skip to content

Fix for received destroy#8

Merged
wilk merged 1 commit intowilk:masterfrom
briantopping:master
May 12, 2014
Merged

Fix for received destroy#8
wilk merged 1 commit intowilk:masterfrom
briantopping:master

Conversation

@briantopping
Copy link
Copy Markdown

When a destroy event is received, the code tries to load the data instead of delete it. Fix attached.

wilk added a commit that referenced this pull request May 12, 2014
Fix for received destroy
@wilk wilk merged commit 0369438 into wilk:master May 12, 2014
@briantopping
Copy link
Copy Markdown
Author

Thanks for applying! You may be interested to see https://github.com/elasticmodules/demo. It's a demo that bundles up your code with a server written in Scala. Please let me know if there are any issues or concerns with this, otherwise hope it's nice to see your work getting some mileage! :)

@wilk
Copy link
Copy Markdown
Owner

wilk commented May 12, 2014

Thank you for your contribution =)

Yeah, I see: it's really interesting and it could be integrated with Ext.ux.data.proxy.WebSocket as an alternative example!

I tried your demo but I had to go on http://localhost/demo/src/main/resources/webapp/ to make it work.
When I type http://localhost:8080 it returns: "The requested resource could not be found."
Maybe, I'm missing something.

However, I updated Ext.ux.data.proxy.WebSocket to version 0.0.5: I suggest you to update the internal version of the extension in your demo ;)

Cheers!
Wilk

@briantopping
Copy link
Copy Markdown
Author

Hi Wilk, thanks for accepting my PR, the feedback and testing the app! I had the wrong URL, was confusing it with some other code that does a redirect when it hits the root. I updated the docs, will get the redirect in there at some point.

Also, I updated the code that is embedded in the project. As a matter of style, could I ask you to critique my use of Bower? I had never heard of it before your project and am totally sold on it, just don't know if I'm using "best practices" with it. (If there's an RTFM on it, just say so! :-))

best, Brian

@wilk
Copy link
Copy Markdown
Owner

wilk commented May 16, 2014

Good! Now it works ;)

Well, Bower is a package manager (as well as Maven for Java) for front-end libraries and frameworks, such as JQuery, AngularJS, Bootstrap and so on.
It supports full integration with GIT and SVN, in particular with GitHub: in fact, you can publish your libraries and frameworks through Bower by linking your github public repo and then use them in other projects.
Also, it's used to handle dependencies of your client-side web application.

In your case, it's useless because you're developing a demo that is quite different from a library or a framework :P
What I mean is that a demo won't be used as a dependency by another application.
So, just use Bower to install all the dependencies your demo needs to work (at client-side, of course) ;)

Cheers!
Wilk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants