Fix for received destroy#8
Conversation
|
Thanks for applying! You may be interested to see https://github.com/elasticmodules/demo. It's a demo that bundles up your code with a server written in Scala. Please let me know if there are any issues or concerns with this, otherwise hope it's nice to see your work getting some mileage! :) |
|
Thank you for your contribution =) Yeah, I see: it's really interesting and it could be integrated with Ext.ux.data.proxy.WebSocket as an alternative example! I tried your demo but I had to go on http://localhost/demo/src/main/resources/webapp/ to make it work. However, I updated Ext.ux.data.proxy.WebSocket to version 0.0.5: I suggest you to update the internal version of the extension in your demo ;) Cheers! |
|
Hi Wilk, thanks for accepting my PR, the feedback and testing the app! I had the wrong URL, was confusing it with some other code that does a redirect when it hits the root. I updated the docs, will get the redirect in there at some point. Also, I updated the code that is embedded in the project. As a matter of style, could I ask you to critique my use of Bower? I had never heard of it before your project and am totally sold on it, just don't know if I'm using "best practices" with it. (If there's an RTFM on it, just say so! :-)) best, Brian |
|
Good! Now it works ;) Well, Bower is a package manager (as well as Maven for Java) for front-end libraries and frameworks, such as JQuery, AngularJS, Bootstrap and so on. In your case, it's useless because you're developing a demo that is quite different from a library or a framework :P Cheers! |
When a destroy event is received, the code tries to load the data instead of delete it. Fix attached.