-
Notifications
You must be signed in to change notification settings - Fork 40
Support reliable, cross-host, cross-process backtraces #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes 'opam pin add xapi-idl .' work more smoothly. Signed-off-by: David Scott <[email protected]>
This exception allows an SR_BACKEND_FAILURE to be accompanied by a backtrace from the SM backend. Note that rpc-idl fails to marshal an exception containing a triple, so we cheat and use a pair, where the first element of the string list is a s-expression marshalled Backtrace.t. Signed-off-by: David Scott <[email protected]>
This field will contain an s-expression marshalled Backtrace.t value. Signed-off-by: David Scott <[email protected]>
- make sure we preserve backtraces when exceptions are caught in helper functions - when an exception hits the top-level thread wrapper functions, log it and the backtrace to the log. If an exception is being handled then by default the backtrace will not be printed: it's up to the higher-level code what to do with it. Signed-off-by: David Scott <[email protected]>
Signed-off-by: David Scott <[email protected]>
Collaborator
Author
|
Example of backtrace you now get: |
Collaborator
|
How exciting :) |
Collaborator
Author
|
OK to merge after chat with @jonludlam. We do need to think more about storage interface backward compatibility though |
djs55
added a commit
that referenced
this pull request
Nov 4, 2014
Support reliable, cross-host, cross-process backtraces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/djs55/xen-api/blob/experimental-exceptions/docs/design/backtraces.md
This needs to be simultaneously merged with:
NB this removes the manual 'name_thread' functions which were leaking in a few places. Please now use Debug.with_thread_named.