This repository was archived by the owner on Feb 19, 2025. It is now read-only.
[CA-125856], [SCTX-1588]: Fixed the slow AD logon for users with large roup memberships, by not caching the names of the AD groups the user belongs to. #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
MihaelaStoica
commented
Jan 22, 2014
MihaelaStoica
commented
- deprecated UserDetails.GroupMembershipNames property and created a function that can be used to get the group names when required.
added 2 commits
January 22, 2014 11:23
…e group memberships, by not caching the names of the AD groups the user belongs to. - deprecated UserDetails.GroupMembershipNames property and created a function that can be used to get the group names when required.
…e group memberships. Added some improvements to the UserDetails class: - kept the UserDetails.GroupMembershipNames property and added a function to get the group names once and then cache them. - optimized the code for getting user details.
|
Looks ok to me. |
kc284
pushed a commit
that referenced
this pull request
Jan 22, 2014
[CA-125856], [SCTX-1588]: Fixed the slow AD logon for users with large roup memberships, by not caching the names of the AD groups the user belongs to.
Collaborator
Author
|
Group names are not cached when the other user details are cached (in the constructor), but only when the UserDetails.GroupMembershipNames property is first used. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.