This repository was archived by the owner on Feb 19, 2025. It is now read-only.
Temporary code change to output extra troubleshooting info for VM.get_record #188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MihaelaStoica
approved these changes
Aug 31, 2021
danilo-delbusso
suggested changes
Aug 31, 2021
csharp/autogen/src/JsonRpc.cs
Outdated
Comment on lines
272
to
275
| var responseProperties = TypeDescriptor.GetProperties(webRequest); | ||
| var responseSb = new StringBuilder("*** WebResponse Properties:\n"); | ||
| foreach (PropertyDescriptor prop in responseProperties) | ||
| responseSb.AppendFormat("{0} {1}={2}\n", prop.PropertyType, prop.Name, prop.GetValue(webRequest)); |
Member
There was a problem hiding this comment.
You're using TypeDescriptor.GetProperties with webRequest, but trying to list properties of the web response. This will create an almost identical string between responseSb and requestSb.
Not sure this was on purpose.
Author
There was a problem hiding this comment.
More like a stupid copy-paste error... 😵
…_record. Signed-off-by: Konstantina Chremmou <[email protected]>
danilo-delbusso
approved these changes
Sep 1, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.