Revert "CA-339526 make gc_compact call public" #4113
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This leads to a build failure in the SDK generator. Reverting it for the moment. This reverts commit d39fcf2. Signed-off-by: Christian Lindig <[email protected]>
kc284
approved these changes
May 27, 2020
|
SDK correction: xapi-project/xen-api-sdk#174 |
Contributor
Author
|
@kc284 do you expect the SDK fix to be merge quickly such that we don't need this revert? |
lippirk
approved these changes
May 28, 2020
|
I hope so, I'll ping the team. Of course, you're welcome to contribute 😉 |
Contributor
Author
|
The SDK was updated - this is no longer needed to fix the build. |
Member
|
Now XC has been fixed so that we this call can be internal-only again: xenserver/xenadmin#2684. @lindig could you reopen this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This leads to a build failure in the SDK generator. Reverting it for the
moment.
This reverts commit d39fcf2.