Implement PVS_proxy module #7
Conversation
|
Needs xenserver/xcp-idl#5. |
| get () | ||
| in | ||
| get (); | ||
| Buffer.contents buf |
There was a problem hiding this comment.
This function looks OK, but how about some tests? 😉 Also the module could do with a .mli
There was a problem hiding this comment.
Can't we use a JSON library? The JSON syntax is not complicated but I don't have a lot of faith that this covers all cases. A good summary is here: http://json.org.
There was a problem hiding this comment.
We are using a JSON-RPC library to create the calls and parse the responses: ocaml-rpc. However, for the transport layer, ocaml-rpc only supports HTTP, while we agreed to use a "raw" stream socket for this. Ideally, we'd eventually upstream this into ocaml-rpc.
Signed-off-by: Rob Hoes <[email protected]>
Signed-off-by: Rob Hoes <[email protected]>
robhoes
force-pushed
the
trunk-pvs-direct
branch
from
7420dcd to
cf268bd
Compare
Signed-off-by: Rob Hoes <[email protected]>
Signed-off-by: Rob Hoes <[email protected]>
robhoes
force-pushed
the
trunk-pvs-direct
branch
from
cf268bd to
e40a491
Compare
|
@johnelse Could you re-review please? |
| let configure_farm _ dbg config = | ||
| debug "Configuring PVS proxy for farm %s" config.farm_uuid; | ||
| let call = {Rpc.name = "configure_farm"; params = [rpc_of_t config]} in | ||
| let _ = do_call call in |
There was a problem hiding this comment.
Do we need to handle any errors returned from the server here?
There was a problem hiding this comment.
Yes, but at this point, we don't know which errors the daemon may return yet. We will have to fill this in later.
3 participants
No description provided.