CP-18170: Handle new Vif.pvs_proxy field and VIF.set_pvs_proxy #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rob Hoes <[email protected]>
We add PVS proxy keys to the "extra" private key map for setup-pvs-proxy-rules to process. Previously, xapi would include the xenstore keys in the VIF metadata, but now xapi uses the new Vif.pvs_proxy field and xenopsd translates it into xenstore keys. To recap, in xenstore, it looks as follows: /xapi/<uuid>/private/vif/0/pvs-interface = "pvs-xenbr0" /xapi/<uuid>/private/vif/0/pvs-server-num = "2" /xapi/<uuid>/private/vif/0/pvs-server-0-addresses = "192.168.0.1,192.168.0.2" /xapi/<uuid>/private/vif/0/pvs-server-0-ports = "5000-5020" /xapi/<uuid>/private/vif/0/pvs-server-1-addresses = "192.168.0.3,192.168.0.4" /xapi/<uuid>/private/vif/0/pvs-server-1-ports = "5000-5020" Signed-off-by: Rob Hoes <[email protected]>
Author
|
Depends on xenserver/xcp-idl#6. |
Author
|
@lindig Could you review this please? |
|
I don't have the design entirely in my head but the code looks on the smaller level really solid. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.