Skip to content

Update to pydantic 2 #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
d-v-b merged 7 commits into from
Oct 28, 2023
Merged

Update to pydantic 2 #9

d-v-b merged 7 commits into from
Oct 28, 2023

Conversation

@clbarnes
Copy link
Contributor

@clbarnes clbarnes commented Jul 11, 2023 •
edited
Loading

Resolves #4

  • Use new-fangled syntax
    • depend on typing-extensions for py<3.12
  • Change error messages in doctests
  • Bump black, ruff dependencies for compatibility with pytest-examples
  • Add black and ruff to dev dependencies (fixed versions)

@clbarnes
Update to pydantic 2
dbc152e 
- Use new-fangled syntax
  - depend on typing-extensions for py<3.12
- Change error messages in doctests
- Bump black, ruff dependencies for compatibility with pytest-examples
- Add black and ruff to dev dependencies (fixed versions)
clbarnes
clbarnes commented Jul 11, 2023
View reviewed changes
src/pydantic_zarr/core.py Outdated
fill_value=zarray.fill_value,
# explicitly cast to numpy type and back to python
# so that int 0 isn't serialized as 0.0
fill_value=zarray.dtype.type(zarray.fill_value).tolist(),
Copy link
Contributor Author

@clbarnes clbarnes Jul 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is worth noting

Copy link
Collaborator

@d-v-b d-v-b Jul 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

@d-v-b
Copy link
Collaborator

d-v-b commented Oct 27, 2023

@clbarnes I pushed a lot of changes into this branch. perhaps the most important is the addition of this test which is currently failing. Pydantic 2 changed how it handles unions, and for some reason it's not doing the right thing here -- a ArraySpec in dict form gets parsed as a GroupSpec, when it really shouldn't. Do you have any ideas for sorting this out? I don't think we can use Annotated here, or at least when I tried to use Annotated around a TypeVar used in generics I got some angry errors.

@d-v-b
Copy link
Collaborator

d-v-b commented Oct 27, 2023

OK, this was my mistake, and it's now fixed (by re-adding the "no extra fields" constraint on the base model for array and group specs)

@d-v-b
Copy link
Collaborator

d-v-b commented Oct 27, 2023

I'm can't understand why this test is failing. Any ideas @clbarnes ?

@d-v-b d-v-b merged commit 882b7f1 into zarr-developers:main Oct 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@d-v-b d-v-b d-v-b left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

pydantic 2.0

2 participants

@clbarnes @d-v-b