Skip to content
This repository was archived by the owner on Feb 28, 2025. It is now read-only.

Conversation

@drknzz
Copy link
Contributor

@drknzz drknzz commented Nov 3, 2022

Adapt to RPC v0.2.1

Significantly smaller PR than for previous versions, introducing changes in RPC v0.2.0 - v0.2.1.

Checklist:

  • Applied formatting - ./scripts/format.sh
  • No linter errors - ./scripts/lint.sh
  • Performed code self-review
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Documented the changes
  • Updated the tests
  • All tests are passing

# Conflicts:
#	starknet_devnet/blueprints/rpc/call.py
#	starknet_devnet/blueprints/rpc/structures/payloads.py
#	starknet_devnet/blueprints/rpc/structures/types.py
#	starknet_devnet/blueprints/rpc/transactions.py
#	test/rpc/test_rpc_estimate_fee.py
@drknzz drknzz requested a review from FabijanC November 8, 2022 10:49
Copy link
Contributor

@FabijanC FabijanC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to make sure I understood the new changes, you added two new tests: test_get_transaction_by_hash_deploy_account and test_get_deploy_account_transaction_receipt?

@drknzz
Copy link
Contributor Author

drknzz commented Nov 8, 2022

Just to make sure I understood the new changes, you added two new tests: test_get_transaction_by_hash_deploy_account and test_get_deploy_account_transaction_receipt?

Yes, as they are places where the new transaction type can occur.

@drknzz drknzz requested a review from FabijanC November 8, 2022 13:05
@FabijanC FabijanC merged commit 3c5600d into 0xSpaceShard:master Nov 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants