Fix render stability of IconPicker grid and update usage of deprecated Dropdown property

[fabiankaegy]

Description of the Change

Fix how the IconGrid gets rendered inside the Icon Picker in order to prevent unwanted rerenders of the component. This should fix the issue described in #229. Whilst working in the codebase I also updated the usage of the deprecated placement prop of the Dropdown component (#226).

Closes #226, #229

How to test the Change

1. Open the IconPicker
2. Change the selected icon / type in the search bar

Expected Result:
The icons should not revert to a Spinner state when the state changes. Also, the browser console should not show any warnings.

Changelog Entry

Fixed - Prevent unintentional rerenders of IconGrid inside IconPicker component

Credits

Props @fabiankaegy, @benlk

Checklist:

• I agree to follow this project's Code of Conduct.
• I have updated the documentation accordingly.
• I have added tests to cover my change.
• All new and existing tests pass.

[github-actions]

Size Change: +78 B (0%)

Total Size: 52.3 kB

Filename	Size	Change
dist/index.js	52.3 kB	+78 B (0%)

_{compressed-size-action}

[fabiankaegy]

@benlk In order to make it easier for you to test I published this as an alpha version to npm. You can install it like so:

npm i @10up/[email protected]

[fabiankaegy]

@Antonio-Laguna just pinging you here to ensure you saw this. I will be out for the next two weeks starting tomorrow but I don't want this to stall out during that time :)

(The failing e2e tests are unrelated and as far as I know @Sidsector9 is looking at them)

[Antonio-Laguna]

LGTM

[Antonio-Laguna]

@fabiankaegy thanks for pinging, I did see it but somehow it got missed!

[benlk]

Tested locally with npm i @10up/[email protected] and the same components that I used when reporting #229 and #226:

• IconPicker now doesn't fluctuate when typing: Icon component: Block updates cause Icon to temporarily revert to Spinner, causing jiggles #229 passes
• the error message seen in IconPicker: position prop in wp.components.Dropdown is deprecated since version 6.2 #226 does not reoccur

[Antonio-Laguna]

@benlk if you review we can get this merged and released as @next

[benlk]

Approved.

[benlk]

Correction: approved with suggestion for extra work.