Re-enable media-related operations on wasm #159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update to Assistants example * Update examples/assistants/src/main.rs update api config for consistency and secutity Co-authored-by: Himanshu Neema <[email protected]> * added assistant creation * exit, deconstruct assistant, improved readme --------- Co-authored-by: Himanshu Neema <[email protected]>
* Link to openai-func-enums * Link to openai-func-enums * Update async-openai/README.md --------- Co-authored-by: Himanshu Neema <[email protected]>
* Added ability to use in-memory files (Bytes, vec[u8]) * Removed unnecessary trait impls * Polished example
* get latest spec * update description * add WASM * WASM support on experiments branch
* changed to allow Send. * add simple tests for sendable * fix test name
# Conflicts: # async-openai/src/types/impls.rs # async-openai/src/types/types.rs
and configure feature gates for items in a finer-grained level. Thanks to PR 64bit#154
ifsheldon
changed the title
|
Nice work for closing more gaps! |
|
Thank you for PR! |
64bit
approved these changes
Nov 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to #154 , media-related operations are decoupled from file-related operations, so they can be re-enabled. For those who want media-related operations on wasm, they can do file-operation via web APIs first.
This PR includes:
Besides, I think wasm support is almost ready to get merged into main branch, except that we need a few examples.