Skip to content

fix: enable udp by default for clash proxies #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fxjs wants to merge 1 commit into
base: main
Choose a base branch
from
+41 −4
Open

fix: enable udp by default for clash proxies #360

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions src/builders/ClashConfigBuilder.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,13 @@ function supportsMrsFormat(userAgent) {
return true;
}

function getClashUdpValue(proxy, defaultEnabled = true) {
if (typeof proxy?.udp !== 'undefined') {
return proxy.udp;
}
return defaultEnabled;
}

export class ClashConfigBuilder extends BaseConfigBuilder {
constructor(inputString, selectedRules, customRules, baseConfig, lang, userAgent, groupByCountry = false, enableClashUI = false, externalController, externalUiDownloadUrl, includeAutoSelect = true) {
if (!baseConfig) {
Expand Down Expand Up @@ -126,7 +133,7 @@ export class ClashConfigBuilder extends BaseConfigBuilder {
port: proxy.server_port,
cipher: proxy.method,
password: proxy.password,
...(typeof proxy.udp !== 'undefined' ? { udp: proxy.udp } : {}),
udp: getClashUdpValue(proxy),
...(proxy.plugin ? { plugin: proxy.plugin } : {}),
...(proxy.plugin_opts ? { 'plugin-opts': proxy.plugin_opts } : {})
};
Expand Down Expand Up @@ -171,7 +178,8 @@ export class ClashConfigBuilder extends BaseConfigBuilder {
path: proxy.transport.path,
host: proxy.transport.host
}
: undefined
: undefined,
udp: getClashUdpValue(proxy)
};
case 'vless':
return {
Expand All @@ -198,7 +206,7 @@ export class ClashConfigBuilder extends BaseConfigBuilder {
} : undefined,
tfo: proxy.tcp_fast_open,
'skip-cert-verify': !!proxy.tls?.insecure,
...(typeof proxy.udp !== 'undefined' ? { udp: proxy.udp } : {}),
udp: getClashUdpValue(proxy),
...(proxy.alpn ? { alpn: proxy.alpn } : {}),
...(proxy.packet_encoding ? { 'packet-encoding': proxy.packet_encoding } : {}),
'flow': proxy.flow ?? undefined,
Expand Down Expand Up @@ -250,6 +258,7 @@ export class ClashConfigBuilder extends BaseConfigBuilder {
'skip-cert-verify': !!proxy.tls?.insecure,
...(proxy.alpn ? { alpn: proxy.alpn } : {}),
'flow': proxy.flow ?? undefined,
udp: getClashUdpValue(proxy),
};
case 'tuic':
return {
Expand All @@ -276,7 +285,7 @@ export class ClashConfigBuilder extends BaseConfigBuilder {
server: proxy.server,
port: proxy.server_port,
password: proxy.password,
...(proxy.udp !== undefined ? { udp: proxy.udp } : {}),
udp: getClashUdpValue(proxy),
...(proxy.tls?.utls?.fingerprint ? { 'client-fingerprint': proxy.tls.utls.fingerprint } : {}),
...(proxy.tls?.server_name ? { sni: proxy.tls.server_name } : {}),
...(proxy.tls?.insecure !== undefined ? { 'skip-cert-verify': !!proxy.tls.insecure } : {}),
Expand Down
28 changes: 28 additions & 0 deletions test/udp-handling.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { describe, it, expect } from 'vitest';
import yaml from 'js-yaml';
import { SingboxConfigBuilder } from '../src/builders/SingboxConfigBuilder.js';
import { ClashConfigBuilder } from '../src/builders/ClashConfigBuilder.js';
import { parseVless } from '../src/parsers/protocols/vlessParser.js';
Expand Down Expand Up @@ -88,6 +89,33 @@ describe('UDP handling in proxy conversion', () => {
expect(converted.name).toBe('TestProxy');
expect(converted.type).toBe('vless');
});

it('should enable udp by default for Clash proxies built from URI subscriptions', async () => {
const input = 'ss://YWVzLTEyOC1nY206dGVzdA@example.com:443#TestSS';
const builder = new ClashConfigBuilder(input, 'minimal', [], null, 'zh-CN', null);
const built = yaml.load(await builder.build());

expect(built.proxies).toHaveLength(1);
expect(built.proxies[0].type).toBe('ss');
expect(built.proxies[0].udp).toBe(true);
});

it('should keep explicit udp=false when generating Clash proxies', () => {
const proxyWithDisabledUdp = {
tag: 'TestProxy',
type: 'vmess',
server: 'example.com',
server_port: 443,
uuid: 'test-uuid',
udp: false,
tls: { enabled: true, server_name: 'example.com' }
};

const builder = new ClashConfigBuilder('', [], [], null, 'zh-CN', null);
const converted = builder.convertProxy(proxyWithDisabledUdp);

expect(converted.udp).toBe(false);
});
});

describe('Clash YAML to sing-box conversion should strip udp', () => {
Expand Down