Skip to content

Commit a2d056b

Browse files
susnuxAIlkiv
authored andcommitted
fix: recommended apps button test
Regression of nextcloud#52703 where the `>` was added by accident and thus the button has a wrong label including the rest of the button HTML. Signed-off-by: Ferdinand Thiessen <[email protected]>
1 parent 9e70166 commit a2d056b

File tree

2 files changed

+16
-6
lines changed

2 files changed

+16
-6
lines changed

core/src/components/setup/RecommendedApps.vue

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -38,17 +38,16 @@
3838

3939
<div class="dialog-row">
4040
<NcButton v-if="showInstallButton && !installingApps"
41-
type="tertiary"
42-
role="link"
41+
data-cy-setup-recommended-apps-skip
4342
:href="defaultPageUrl"
44-
data-cy-setup-recommended-apps-skip>
43+
variant="tertiary">
4544
{{ t('core', 'Skip') }}
4645
</NcButton>
4746

4847
<NcButton v-if="showInstallButton"
49-
type="primary"
48+
data-cy-setup-recommended-apps-install
5049
:disabled="installingApps || !isAnyAppSelected"
51-
data-cy-setup-recommended-apps-install>
50+
variant="primary"
5251
@click.stop.prevent="installApps">
5352
{{ installingApps ? t('core', 'Installing apps …') : t('core', 'Install recommended apps') }}
5453
</NcButton>

cypress/e2e/core/setup.ts

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,8 +124,19 @@ function sharedSetup() {
124124
cy.location('pathname', { timeout: 10000 })
125125
.should('include', '/core/apps/recommended')
126126

127+
// See the apps setup
128+
cy.get('[data-cy-setup-recommended-apps]')
129+
.should('be.visible')
130+
.within(() => {
131+
cy.findByRole('heading', { name: 'Recommended apps' })
132+
.should('be.visible')
133+
cy.findByRole('link', { name: 'Skip' })
134+
.should('be.visible')
135+
cy.findByRole('button', { name: 'Install recommended apps' })
136+
.should('be.visible')
137+
})
138+
127139
// Skip the setup apps
128-
cy.get('[data-cy-setup-recommended-apps]').should('be.visible')
129140
cy.get('[data-cy-setup-recommended-apps-skip]').click()
130141

131142
// Go to files

0 commit comments

Comments
 (0)