Skip to content

chore(cypress): add setup tests #52703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skjnldsv merged 1 commit into from
May 12, 2025
Merged

chore(cypress): add setup tests #52703

skjnldsv merged 1 commit into from
May 12, 2025

Conversation

@skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented May 9, 2025 •
edited
Loading

  • SQLite
  • MySQL
  • Mariadb
  • Postgre

Technical challenges

  • When cypress starts, the docker container it runs within is already set-up
  • It means we need to clear the current setup
  • To avoid interfering with other tests, I created a dedicated one
  • It uses github integrated services for to reasons
    1. Ease of use, it automatically waits for healthcheck and handle a global bridge network as well as service name DNS resolution
    2. It's a clone from each phpunit workflows, so we're consistent
  • So the only changes done are basically retrieving the random github network and make sure the server container is on the same bridge so you can communicate with each DB services

PS: oracle requires some php dependencies within the shallow server, so it will be a followup

Once merged

  • Make the runner setup check mandatory ?

Followup

  • Oracle

@skjnldsv skjnldsv force-pushed the feat/setup-checks branch 18 times, most recently from 682312e to cf2f252 Compare May 9, 2025 19:58
@skjnldsv skjnldsv force-pushed the feat/setup-checks branch from cf2f252 to 3dbc479 Compare May 9, 2025 19:59
@skjnldsv skjnldsv self-assigned this May 9, 2025
@skjnldsv skjnldsv added 3. to review Waiting for reviews technical debt labels May 9, 2025
@skjnldsv skjnldsv added this to the Nextcloud 32 milestone May 9, 2025
@github-project-automation github-project-automation bot moved this to 🏗️ In progress in 📁 Files team May 9, 2025
@skjnldsv skjnldsv added the tests Related to tests label May 9, 2025
@skjnldsv
Copy link
Member Author

skjnldsv commented May 9, 2025 •
edited
Loading

Ready for reviews! 🎉
image

@skjnldsv skjnldsv marked this pull request as ready for review May 9, 2025 20:09
@skjnldsv skjnldsv requested a review from a team as a code owner May 9, 2025 20:09
@skjnldsv skjnldsv requested review from artonge, nfebe, sorbaugh and szaimen and removed request for a team May 9, 2025 20:09
@skjnldsv skjnldsv enabled auto-merge May 10, 2025 05:15
@skjnldsv skjnldsv requested a review from susnux May 10, 2025 05:15
szaimen
szaimen approved these changes May 12, 2025
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@skjnldsv skjnldsv merged commit ff1dfc6 into master May 12, 2025
210 of 212 checks passed
@skjnldsv skjnldsv deleted the feat/setup-checks branch May 12, 2025 09:05
@skjnldsv
Copy link
Member Author

skjnldsv commented May 12, 2025

/backport to stable31

@backportbot backportbot bot mentioned this pull request May 12, 2025
Closed
2 tasks
@skjnldsv skjnldsv mentioned this pull request May 12, 2025
Merged
2 tasks
susnux added a commit that referenced this pull request May 22, 2025
@susnux
fix: recommended apps button test
77812a3 
Regression of #52703 where the
`>` was added by accident and thus the button has a wrong label
including the rest of the button HTML.

Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux added a commit that referenced this pull request May 22, 2025
@susnux
fix: recommended apps button test
b18020b 
Regression of #52703 where the
`>` was added by accident and thus the button has a wrong label
including the rest of the button HTML.

Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux susnux mentioned this pull request May 22, 2025
Merged
4 tasks
susnux added a commit that referenced this pull request May 22, 2025
@susnux
fix: recommended apps button test
8a96df5 
Regression of #52703 where the
`>` was added by accident and thus the button has a wrong label
including the rest of the button HTML.

Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux added a commit that referenced this pull request May 22, 2025
@susnux
fix: recommended apps button test
07538fa 
Regression of #52703 where the
`>` was added by accident and thus the button has a wrong label
including the rest of the button HTML.

Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux added a commit that referenced this pull request May 28, 2025
@susnux
fix: recommended apps button test
bcda568 
Regression of #52703 where the
`>` was added by accident and thus the button has a wrong label
including the rest of the button HTML.

Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux added a commit that referenced this pull request May 28, 2025
@susnux
fix: recommended apps button test
d535c37 
Regression of #52703 where the
`>` was added by accident and thus the button has a wrong label
including the rest of the button HTML.

Signed-off-by: Ferdinand Thiessen <[email protected]>
@skjnldsv skjnldsv moved this from 🏗️ In progress to ☑️ Done in 📁 Files team Jun 4, 2025
AIlkiv pushed a commit to AIlkiv/server that referenced this pull request Jul 10, 2025
@susnux @AIlkiv
fix: recommended apps button test
a2d056b 
Regression of nextcloud#52703 where the
`>` was added by accident and thus the button has a wrong label
including the rest of the button HTML.

Signed-off-by: Ferdinand Thiessen <[email protected]>
@skjnldsv skjnldsv mentioned this pull request Aug 19, 2025
Merged
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@susnux susnux susnux approved these changes

@szaimen szaimen szaimen approved these changes

@artonge artonge Awaiting requested review from artonge artonge is a code owner automatically assigned from nextcloud/server-frontend

@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh is a code owner automatically assigned from nextcloud/server-frontend

@nfebe nfebe Awaiting requested review from nfebe nfebe is a code owner automatically assigned from nextcloud/server-backend

Assignees

@skjnldsv skjnldsv

Labels

3. to review Waiting for reviews technical debt tests Related to tests

Projects

📁 Files team
Status: ☑️ Done

Milestone

Nextcloud 32

Development

Successfully merging this pull request may close these issues.

4 participants

@skjnldsv @susnux @szaimen