Travis testing centos/ubuntu with docker #138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farridav
force-pushed
the
farridav/docker_testing
branch
from
a5ca409 to
f3a47ef
Compare
farridav
changed the title
Contributor
|
Great job, this is the way to go even if it's slower. I would promote Debian too, as there could be some minor differences with Ubuntu regarding locales or whatever. But the CentOS support is the priority. |
Author
|
I'm keen to get this into master so that we can at least build on centos with travis runs.. In separate PR's I plan to do the following:
Happy to coordinate my efforts with and review any contributions for the above |
Author
|
Merging this in as its non breaking and will at least get the ball rolling with building on centos hosts .. times a little limited lately |
farridav
pushed a commit
that referenced
this pull request
Feb 8, 2016
Travis testing centos/ubuntu with docker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aims to get the role running against a centos host, and makes a first rough stab at #115...
I'm trying to find the time to work through the issues and pull requests in this repo, though now we have centos support, I'm increasing aware that every bit of new code will need to be tested on centos.. so getting this code up prematurely to ensure we are at least building (albeit a little slow, and not testing idempotence.. yet)
Fixes #115