Convert rebase token amount when calculate swap amount for StableAsset #2169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangjj9219
changed the title
zqhxuyuan
reviewed
May 30, 2022
zqhxuyuan
reviewed
May 30, 2022
xlc
reviewed
May 30, 2022
Member
xlc
left a comment
xlc
left a comment
There was a problem hiding this comment.
Another way to handle the rebase token is to create another implementation of StableAsset that wraps the original one and handle the rebase logic there.
Member
Author
You are right, it's better to add a wrapper to hide the processing logic, and it will be easier to use for other pallet modules. |
xlc
approved these changes
May 30, 2022
zqhxuyuan
approved these changes
May 31, 2022
syan095
pushed a commit
that referenced
this pull request
Jun 16, 2022
…a into fee_distribution * 'fee_distribution' of ssh://github.com/AcalaNetwork/Acala: (31 commits) update polkadot-v0.9.23 (#2183) make sure acala precompiles are called only from other contracts (#2202) remove AccountId from XcmFeeToTreasury Acala XcmFeeToTreasury fix precompile array encode & other improvements (#2196) move HomaTreasuryPalletId to common update loan proxy type (#2200) Add bifrost (#2199) fix benchmark build_pool_percents helper method benchmark update to v0.9.22 refactor weight trader (#2178) fix with_fee_currency (#2194) Support arm64 (#2107) add Homa to ProxyType (#2191) disable with_fee_paid_by (#2187) Convert rebase token amount when calculate swap amount for StableAsset (#2169) 2.7.0 (#2186) fix origin of erc20 xtokens transfer (#2180) ... # Conflicts: # modules/cdp-engine/src/lib.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.