Work with 0.8.2 meteor auth #5

jperl · 2014-06-09T20:53:56Z

Features of this PR:

Make phonegap-oauth work with Meteor >= v0.8.2 while maintaining support for the browser-policy package, details below.
Close the InAppBrowser when the auth flow is cancelled by the user.
Close the InAppBrowser on the exit event. This is triggered if the back button is pressed and there is no history (right after it is opened).
Wait until InAppBrowser is loaded before patching the window. This fixes a bug if the meteor application is loaded before cordova is ready -- this will happen if the app is included on the phone locally.
A better workaround for the InAppBrowser eventListener callback not firing, which also fixes the bug on Android where Cordova plugin callbacks are not processed until the next message.

To support Meteor's latest oauth I patch OAuth._endOfLoginResponse to append the credentialToken and credentialSecret to the url hash -- and use them to call OAuth._handleCredentialSecret and Accounts.oauth.tryLoginAfterPopupClosed.

This method works even if the meteor app is using the browser-policy package which prevents inline
scripts from being executed. The executeScript method used in PR #3 will not work under these restrictions since it uses inline scripts.

This PR will only work with Meteor >= v0.8.2, as it relies on OAuth._endOfLoginResponse.

More context here https://groups.google.com/forum/#!topic/meteor-core/Ma3XTZk4Kqg

~~If meteor/meteor#2220 is accepted we can get rid of the OAuth._endOfLoginResponse patch.~~

Since we do not rely on executeScript this will work if Content Security Policy prevents inline scripts.

jperl · 2014-06-09T20:54:07Z

@faceyspacey I did not include that regex modification to make it work for twitter because it broke the LinkedIn oauth. Do you have one that works for all providers?

faceyspacey · 2014-06-10T03:03:01Z

@jperl no but it's simple enough to add another OR clause

…ctly in patch_window.

…uthentication. Remove android show setInterval hack because it breaks the behavior of the InAppBrowser closing when the user presses back. Since loadstop is called without it it is not necessary.

jperl · 2014-06-10T21:32:33Z

@faceyspacey K I checked in some code that should work. Would you mind testing it to see if it works for you?

Also handle exit event -- if the user presses back, close the window.

otherwise it will throw an exception

jperl · 2014-06-16T16:52:26Z

@AdamBrodzinski Have you had a chance to check this out yet?

AdamBrodzinski · 2014-06-16T16:57:41Z

@jperl Not yet, it's on my todo list for tonight or tomorrow though!

AdamBrodzinski · 2014-06-18T02:40:19Z

@jperl I'll try to finish testing on Android tonight... not sure how that will go, my eclipse was botched the last time I tried to compile.

There's a copy running in debug mode on http://oauth-demo.meteor.com with this patch (minus the require mentioned above) if anyone wants to try it out.

I can confirm that if I comment out/change the IAB require, the LinkedIn OAuth and Twitter OAuth are working on iOS7 👍 🍻

jperl · 2014-06-18T04:27:16Z

@AdamBrodzinski Glad it works on twitter. I didn't even test that 😃

Replace setInterval show hack with setInterval exec hack. This will solve problems for other plugins as well.

jperl · 2014-06-20T02:36:05Z

@AdamBrodzinski FYI just committed an improved hack for fixing the event listener callbacks never firing.

AdamBrodzinski · 2014-06-20T17:05:58Z

@jperl Oh wow, I wish I would have seen that a month ago! I lost a lot of hair trying to get the video capture to work. It was only firing the callback on the 2nd capture. 😦 I'm hoping to test on the Galaxy S3 tonight and if all goes well on the Genymotion emulators. I def. want to ship this when 0.8.2 is out!

jperl · 2014-06-20T17:35:18Z

@AdamBrodzinski Yeah I was running into the same problem w the dialog prompt until I tried this. It works on my nexus 5, I hope it works on the S3. fingers crossed

faceyspacey · 2014-06-20T18:14:22Z

@jperl @AdamBrodzinski can you guys send me the code. I was running into the same issue with capture callbacks. I'd like to use it since I know Adam is really busy.

jperl · 2014-06-20T18:16:35Z

@faceyspacey Not sure what you mean exactly. Send you the code that is in this PR? The code that fixes the plugin callbacks is here https://github.com/jperl/meteor-phonegap-oauth/blob/master/patch_window.js#L20-L29

faceyspacey · 2014-06-20T18:20:49Z

oops my bad. i didnt see that i can get it. awesome brother. thanks!

jperl · 2014-06-20T18:23:28Z

@faceyspacey NP. Let me know if it works for you.

tstuber · 2014-06-22T12:58:10Z

hey guys, I'll test that in short as well. But did I got it right, that this will not working with cordova 3.3? Only with 3.4 and 3.5?

Cheers

AdamBrodzinski · 2014-06-22T13:22:02Z

It will work if you make your own local package and then change the require line to use '.InAppBrowser' instead of the lowercased one (on mobile now so I can't reference it). Phone gap recently changed their JS code in 3.4 or 3.5—
Sent from Mailbox

On Sun, Jun 22, 2014 at 8:58 AM, tstuber [email protected] wrote:

hey guys, I'll test that in short as well. But did I got it right, that this will not working with cordova 3.3? Only with 3.4 and 3.5?

Cheers

Reply to this email directly or view it on GitHub:
#5 (comment)

adds functionality to work with new 0.8.2 meteor auth

AdamBrodzinski · 2014-06-23T19:39:45Z

@jperl @faceyspacey thanks for the PRs 🍻

Just tested on Android 4.4 Motox and 4.3 Galaxy S3 and it's working great on both LinkedIn and Twitter 😄

jperl · 2014-06-24T00:32:52Z

Awesome!

faceyspacey and others added 3 commits April 30, 2014 22:10

fixed twitter's ability to actually signup and login the user in

54a8972

Wait for InAppBrowser before patching the window.

210cba9

Pickup the token and secret from the InAppBrowser's url hash.

5943c72

Since we do not rely on executeScript this will work if Content Security Policy prevents inline scripts.

This was referenced Jun 9, 2014

Make OAuth friendlier to Cordova meteor/meteor#2220

Closed

Callback blank page #1

Closed

jperl added 3 commits June 10, 2014 10:20

Clear the timer in IAB.close to prevent the window from reopening.

23503f1

Add oauth and accounts-oauth package dependencies -- access them dire…

c312e5d

…ctly in patch_window.

Add support for twitter. Close oauth window if the user cancels the a…

acae34c

…uthentication. Remove android show setInterval hack because it breaks the behavior of the InAppBrowser closing when the user presses back. Since loadstop is called without it it is not necessary.

jperl added 3 commits June 11, 2014 15:21

Prevent window from being patched twice

d930983

Add android workaround back, we do need it.

dec3420

Also handle exit event -- if the user presses back, close the window.

Wrap inappbrowser check in try catch

3621b22

otherwise it will throw an exception

jperl changed the title ~~Work with vNext Meteor auth~~ Work with 0.8.2 meteor auth Jun 18, 2014

jperl added 2 commits June 19, 2014 22:33

Improve setInterval hack

5dcacdd

Replace setInterval show hack with setInterval exec hack. This will solve problems for other plugins as well.

Add comments

badfb93

AdamBrodzinski added a commit that referenced this pull request Jun 23, 2014

Merge pull request #5 from jperl/master

31201fe

adds functionality to work with new 0.8.2 meteor auth

AdamBrodzinski merged commit 31201fe into AdamBrodzinski:master Jun 23, 2014

AdamBrodzinski mentioned this pull request Jun 23, 2014

No signup/login with v0.8.1 #4

Closed

Work with 0.8.2 meteor auth #5

Work with 0.8.2 meteor auth #5

Uh oh!

Conversation

jperl commented Jun 9, 2014

Uh oh!

jperl commented Jun 9, 2014

Uh oh!

faceyspacey commented Jun 10, 2014

Uh oh!

jperl commented Jun 10, 2014

Uh oh!

jperl commented Jun 16, 2014

Uh oh!

AdamBrodzinski commented Jun 16, 2014

Uh oh!

AdamBrodzinski commented Jun 18, 2014

Uh oh!

jperl commented Jun 18, 2014

Uh oh!

jperl commented Jun 20, 2014

Uh oh!

AdamBrodzinski commented Jun 20, 2014

Uh oh!

jperl commented Jun 20, 2014

Uh oh!

faceyspacey commented Jun 20, 2014

Uh oh!

jperl commented Jun 20, 2014

Uh oh!

faceyspacey commented Jun 20, 2014

Uh oh!

jperl commented Jun 20, 2014

Uh oh!

tstuber commented Jun 22, 2014

Uh oh!

AdamBrodzinski commented Jun 22, 2014

Cheers

Uh oh!

AdamBrodzinski commented Jun 23, 2014

Uh oh!

jperl commented Jun 24, 2014

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants