Skip to content

Fix render mode for AgoraView #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
syanbo merged 1 commit into from
Jun 15, 2020
Merged

Fix render mode for AgoraView #153

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix render mode for AgoraView 
this fix the issue that sometimes wrong render mode are set when the UI is changed
  • Loading branch information
@leethree
leethree authored Apr 9, 2020
commit 0cdb398ac0a2d47100a134f45903f9bec07b427f
19 changes: 10 additions & 9 deletions ios/RCTAgora/RCTAgoraVideoView.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ - (void)setRenderMode:(NSInteger)renderMode {

- (void)setShowLocalVideo:(BOOL)showLocalVideo {
_showLocalVideo = showLocalVideo;
AgoraRtcVideoCanvas *canvas = [[AgoraRtcVideoCanvas alloc] init];
if (_showLocalVideo) {
AgoraRtcVideoCanvas *canvas = [[AgoraRtcVideoCanvas alloc] init];
canvas.uid = [AgoraConst share].localUid;
canvas.view = self;
canvas.renderMode = _renderMode;
Expand All @@ -38,22 +38,23 @@ - (void)setShowLocalVideo:(BOOL)showLocalVideo {

-(void)setRemoteUid:(NSUInteger)remoteUid {
_remoteUid = remoteUid;
AgoraRtcVideoCanvas *canvas = [[AgoraRtcVideoCanvas alloc] init];
if (_remoteUid != 0) {
AgoraRtcVideoCanvas *canvas = [[AgoraRtcVideoCanvas alloc] init];
canvas.uid = _remoteUid;
canvas.view = self;
canvas.renderMode = _renderMode;
[_rtcEngine setupRemoteVideo:canvas];
return;
}
}

-(void) willMoveToSuperview:(UIView *)newSuperview {
[super willMoveToSuperview:newSuperview];
if (_remoteUid > 0) {
[_rtcEngine setRemoteRenderMode:_remoteUid mode:_renderMode];
} else {
[_rtcEngine setLocalRenderMode:_renderMode];
-(void) didMoveToWindow {
[super didMoveToWindow];
if (self.window != nil) {
if (_remoteUid > 0) {
[_rtcEngine setRemoteRenderMode:_remoteUid mode:_renderMode];
} else {
[_rtcEngine setLocalRenderMode:_renderMode];
}
}
}

Expand Down