- fix iOS deinit [weak self] crash

  - fix `engine()` build error

CHANGELOG.md

@@ -1,5 +1,9 @@
 ## THE CHANGELOG
 
+#### 3.1.2-rc.2
+  - fix iOS `deinit` `[weak self]` crash
+  - fix `engine()` build error
+
 #### 3.1.2-rc.1
   - make `RtcChannel.channelId` public
 

ios/RCTAgora/React/RCTAgoraRtcChannelModule.swift

@@ -14,11 +14,18 @@ class RCTAgoraRtcChannelModule: RCTEventEmitter {
     static let REACT_CLASS = "RCTAgoraRtcChannelModule"
 
     private var hasListeners = false
-    private lazy var manager: RtcChannelManager = {
-        return RtcChannelManager() { [weak self] methodName, data in
+    private var manager: RtcChannelManager?
+
+    override init() {
+        super.init()
+        manager = RtcChannelManager() { [weak self] methodName, data in
             self?.emit(methodName, data)
         }
-    }()
+    }
+
+    deinit {
+        manager?.Release()
+    }
 
     override class func moduleName() -> String! {
         return RCTAgoraRtcChannelModule.REACT_CLASS
@@ -28,10 +35,6 @@ class RCTAgoraRtcChannelModule: RCTEventEmitter {
         return ["prefix": RtcChannelEventHandler.PREFIX]
     }
 
-    deinit {
-        manager.Release()
-    }
-
     override class func requiresMainQueueSetup() -> Bool {
         return true
     }
@@ -66,18 +69,18 @@ class RCTAgoraRtcChannelModule: RCTEventEmitter {
         return (bridge.module(for: RCTAgoraRtcEngineModule.classForCoder()) as? RCTAgoraRtcEngineModule)?.engine
     }
 
-    public func channel(_ channelId: String) -> AgoraRtcChannel? {
-        return manager[channelId]
+    func channel(_ channelId: String) -> AgoraRtcChannel? {
+        return manager?[channelId]
     }
 
     @objc func callMethod(_ methodName: String, _ params: NSDictionary?, _ resolve: RCTPromiseResolveBlock?, _ reject: RCTPromiseRejectBlock?) {
         if let `params` = params {
             if methodName == "create" {
-                params.setValue(engine(), forKey: "engine")
+                params.setValue(engine, forKey: "engine")
             }
-            manager.perform(NSSelectorFromString(methodName + "::"), with: params, with: PromiseCallback(resolve, reject))
+            manager?.perform(NSSelectorFromString(methodName + "::"), with: params, with: PromiseCallback(resolve, reject))
         } else {
-            manager.perform(NSSelectorFromString(methodName + ":"), with: PromiseCallback(resolve, reject))
+            manager?.perform(NSSelectorFromString(methodName + ":"), with: PromiseCallback(resolve, reject))
         }
     }
 }

ios/RCTAgora/React/RCTAgoraRtcEngineModule.swift

@@ -14,11 +14,18 @@ class RCTAgoraRtcEngineModule: RCTEventEmitter {
     static let REACT_CLASS = "RCTAgoraRtcEngineModule"
 
     private var hasListeners = false
-    private lazy var manager: RtcEngineManager = {
-        return RtcEngineManager() { [weak self] methodName, data in
+    private var manager: RtcEngineManager?
+
+    override init() {
+        super.init()
+        manager = RtcEngineManager() { [weak self] methodName, data in
             self?.emit(methodName, data)
         }
-    }()
+    }
+
+    deinit {
+        manager?.Release()
+    }
 
     override class func moduleName() -> String! {
         return RCTAgoraRtcEngineModule.REACT_CLASS
@@ -28,10 +35,6 @@ class RCTAgoraRtcEngineModule: RCTEventEmitter {
         return ["prefix": RtcEngineEventHandler.PREFIX]
     }
 
-    deinit {
-        manager.Release()
-    }
-
     override class func requiresMainQueueSetup() -> Bool {
         return true
     }
@@ -63,14 +66,14 @@ class RCTAgoraRtcEngineModule: RCTEventEmitter {
     }
 
     weak var engine: AgoraRtcEngineKit? {
-        return manager.engine
+        return manager?.engine
     }
 
     @objc func callMethod(_ methodName: String, _ params: NSDictionary?, _ resolve: RCTPromiseResolveBlock?, _ reject: RCTPromiseRejectBlock?) {
         if let `params` = params {
-            manager.perform(NSSelectorFromString(methodName + "::"), with: params, with: PromiseCallback(resolve, reject))
+            manager?.perform(NSSelectorFromString(methodName + "::"), with: params, with: PromiseCallback(resolve, reject))
         } else {
-            manager.perform(NSSelectorFromString(methodName + ":"), with: PromiseCallback(resolve, reject))
+            manager?.perform(NSSelectorFromString(methodName + ":"), with: PromiseCallback(resolve, reject))
         }
     }
 }

package.json

@@ -1,6 +1,6 @@
 {
   "name": "react-native-agora",
-  "version": "3.1.2-rc.1",
+  "version": "3.1.2-rc.2",
   "description": "React Native around the Agora RTC SDKs for Android and iOS agora",
   "summary": "agora native sdk for react-native",
   "main": "lib/index.js",