Skip to content
Merged
Show file tree
Hide file tree
Changes from 14 commits
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
680048f
feat: upgrade to 3.2.0
LichKing-2234 Dec 2, 2020
4ee51a9
feat: upgrade to 3.2.0
LichKing-2234 Dec 2, 2020
fcb57cc
feat: upgrade to 3.2.0
LichKing-2234 Dec 2, 2020
642eb32
Merge branch 'master' into dev/3.2.0
LichKing-2234 Dec 2, 2020
e10a633
update en doc
TingChen2020 Dec 3, 2020
984d807
Merge pull request #305 from TingChen2020/dev/3.2.0
LichKing-2234 Dec 4, 2020
76c3a08
update docs
TingChen2020 Dec 15, 2020
daef6ff
Merge pull request #311 from TingChen2020/dev/3.2.0
LichKing-2234 Dec 15, 2020
3a55997
feat: add `setClientRole(role: ClientRole, options?: ClientRoleOption…
LichKing-2234 Dec 15, 2020
2fef3ae
feat: add `setClientRole(role: ClientRole, options?: ClientRoleOption…
LichKing-2234 Dec 15, 2020
721604e
feat: add `setClientRole(role: ClientRole, options?: ClientRoleOption…
LichKing-2234 Dec 15, 2020
da3222a
Merge branch 'master' into dev/3.2.0
LichKing-2234 Dec 15, 2020
7a53134
Update doc
TingChen2020 Dec 16, 2020
561b3fd
Merge branch 'master' into dev/3.2.0
LichKing-2234 Dec 17, 2020
ddeaefb
Merge branch 'master' into dev/3.2.0
LichKing-2234 Dec 17, 2020
6ebc3a1
minor editorial improvement
TingChen2020 Dec 17, 2020
d73653c
minor changes
TingChen2020 Dec 18, 2020
daefc68
style: use shorthand arguments for lambda
LichKing-2234 Dec 18, 2020
56ab25b
fix: `MetadataReceived` event parameters bug
LichKing-2234 Dec 18, 2020
9ab28a7
fix: `MetadataReceived` event parameters bug
LichKing-2234 Dec 18, 2020
a290e73
fix: use the better way to fix rendering problems
LichKing-2234 Dec 18, 2020
75f572d
fix: use the better way to fix rendering problems
LichKing-2234 Dec 18, 2020
c8a08e5
Merge branch 'master' into dev/3.2.0
LichKing-2234 Dec 18, 2020
de52ca6
Merge branch 'master' into dev/3.2.0
LichKing-2234 Dec 18, 2020
558cc61
merge: dev/3.2.0
LichKing-2234 Dec 18, 2020
eb257ec
Merge commit 'c8a08e551ad150f3f52c5c5864e5b80255d6505a' into dev/3.2.0
LichKing-2234 Dec 18, 2020
1966cd8
Merge branch 'rc/3.1.+' into dev/3.2.0
LichKing-2234 Dec 18, 2020
10da71d
docs: Update docs
LichKing-2234 Dec 18, 2020
76403e8
Merge branch 'master' into dev/3.2.0
LichKing-2234 Dec 21, 2020
f301dc4
chore: release 3.2.0-rc.0
LichKing-2234 Dec 21, 2020
503c14d
Add doc changes between v3.1.2 and v3.2.0
TingChen2020 Dec 21, 2020
ac146fa
Merge pull request #315 from TingChen2020/dev/3.2.0
LichKing-2234 Dec 22, 2020
3dcc489
feat: upgrade native SDK to 3.2.1
LichKing-2234 Dec 23, 2020
a98f6bd
chore: release 3.2.0
LichKing-2234 Dec 23, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ios/RCTAgora/Base/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
.idea/
8 changes: 4 additions & 4 deletions ios/RCTAgora/Base/BeanCovertor.swift
Original file line number Diff line number Diff line change
Expand Up @@ -179,8 +179,8 @@ func mapToLiveTranscoding(_ map: Dictionary<String, Any>) -> AgoraLiveTranscodin
transcoding.transcodingExtraInfo = userConfigExtraInfo
}
if let transcodingUsers = map["transcodingUsers"] as? Array<Any> {
transcodingUsers.forEach { (item) in
if let item = item as? Dictionary<String, Any> {
transcodingUsers.forEach {
if let item = $0 as? Dictionary<String, Any> {
transcoding.add(mapToTranscodingUser(item))
}
}
Expand Down Expand Up @@ -208,8 +208,8 @@ func mapToChannelMediaRelayConfiguration(_ map: Dictionary<String, Any>) -> Agor
config.sourceInfo = mapToChannelMediaInfo(srcInfo)
}
if let destInfos = map["destInfos"] as? Array<Any> {
destInfos.forEach { (item) in
if let item = item as? Dictionary<String, Any> {
destInfos.forEach {
if let item = $0 as? Dictionary<String, Any> {
let info = mapToChannelMediaInfo(item)
config.setDestinationInfo(info, forChannelName: info.channelName ?? "")
}
Expand Down
4 changes: 2 additions & 2 deletions ios/RCTAgora/Base/Callback.swift
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,14 @@ protocol Callback: class {
}

extension Callback {
func code(_ code: Int32?, _ runnable: ((Int32) -> Any?)? = nil) {
func code(_ code: Int32?, _ runnable: ((Int32?) -> Any?)? = nil) {
if code == nil || code! < 0 {
let newCode = abs(Int(code ?? Int32(AgoraErrorCode.notInitialized.rawValue)))
failure(String(newCode), AgoraRtcEngineKit.getErrorDescription(newCode) ?? "")
return
}

let res = runnable?(code!)
let res = runnable?(code)
if res is Void {
success(nil)
} else {
Expand Down
8 changes: 4 additions & 4 deletions ios/RCTAgora/Base/Extensions.swift
Original file line number Diff line number Diff line change
Expand Up @@ -144,8 +144,8 @@ extension AgoraRtcAudioVolumeInfo {
extension Array where Element: AgoraRtcAudioVolumeInfo {
func toMapList() -> Array<Dictionary<String, Any?>> {
var list = [Dictionary<String, Any?>]()
self.forEach { (item) in
list.append(item.toMap())
self.forEach {
list.append($0.toMap())
}
return list
}
Expand Down Expand Up @@ -187,8 +187,8 @@ extension AgoraFacePositionInfo {
extension Array where Element: AgoraFacePositionInfo {
func toMapList() -> Array<Dictionary<String, Any?>> {
var list = [Dictionary<String, Any?>]()
self.forEach { (item) in
list.append(item.toMap())
self.forEach {
list.append($0.toMap())
}
return list
}
Expand Down
4 changes: 1 addition & 3 deletions ios/RCTAgora/Base/MediaObserver.swift
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,7 @@ extension MediaObserver: AgoraMediaMetadataDataSource {
extension MediaObserver: AgoraMediaMetadataDelegate {
func receiveMetadata(_ data: Data, fromUser uid: Int, atTimestamp timestamp: TimeInterval) {
emitter([
"buffer": String(data: data, encoding: .utf8),
"uid": uid,
"timeStampMs": timestamp
"data": [String(data: data, encoding: .utf8) ?? "", uid, timestamp]
])
}
}
34 changes: 17 additions & 17 deletions ios/RCTAgora/Base/RtcChannel.swift
Original file line number Diff line number Diff line change
Expand Up @@ -134,8 +134,8 @@ class RtcChannelManager: NSObject, RtcChannelInterface {
}

func Release() {
rtcChannelMap.forEach { key, value in
value.destroy()
rtcChannelMap.forEach {
$1.destroy()
}
rtcChannelMap.removeAll()
rtcChannelDelegateMap.removeAll()
Expand All @@ -149,10 +149,10 @@ class RtcChannelManager: NSObject, RtcChannelInterface {
}

@objc func create(_ params: NSDictionary, _ callback: Callback) {
callback.resolve(params["engine"] as? AgoraRtcEngineKit) { [weak self] it in
if let rtcChannel = it.createRtcChannel(params["channelId"] as! String) {
let delegate = RtcChannelEventHandler() { [weak self] methodName, data in
self?.emitter(methodName, data)
callback.resolve(params["engine"] as? AgoraRtcEngineKit) { [weak self] in
if let rtcChannel = $0.createRtcChannel(params["channelId"] as! String) {
let delegate = RtcChannelEventHandler() { [weak self] in
self?.emitter($0, $1)
}
rtcChannel.setRtcChannelDelegate(delegate)
self?.rtcChannelMap[rtcChannel.getId()!] = rtcChannel
Expand Down Expand Up @@ -196,8 +196,8 @@ class RtcChannelManager: NSObject, RtcChannelInterface {
}

@objc func getConnectionState(_ params: NSDictionary, _ callback: Callback) {
callback.resolve(self[params["channelId"] as! String]) { it in
it.getConnectionState().rawValue
callback.resolve(self[params["channelId"] as! String]) {
$0.getConnectionState().rawValue
}
}

Expand All @@ -210,8 +210,8 @@ class RtcChannelManager: NSObject, RtcChannelInterface {
}

@objc func getCallId(_ params: NSDictionary, _ callback: Callback) {
callback.resolve(self[params["channelId"] as! String]) { it in
it.getCallId()
callback.resolve(self[params["channelId"] as! String]) {
$0.getCallId()
}
}

Expand Down Expand Up @@ -286,8 +286,8 @@ class RtcChannelManager: NSObject, RtcChannelInterface {
@objc func registerMediaMetadataObserver(_ params: NSDictionary, _ callback: Callback) {
var code = -AgoraErrorCode.notInitialized.rawValue
if let it = self[params["channelId"] as! String] {
let mediaObserver = MediaObserver { [weak self] data in
self?.emitter(RtcEngineEvents.MetadataReceived, data)
let mediaObserver = MediaObserver { [weak self] in
self?.emitter(RtcEngineEvents.MetadataReceived, $0)
}
if it.setMediaMetadataDelegate(mediaObserver, with: .video) {
mediaObserverMap[it.getId()!] = mediaObserver
Expand All @@ -309,14 +309,14 @@ class RtcChannelManager: NSObject, RtcChannelInterface {
}

@objc func setMaxMetadataSize(_ params: NSDictionary, _ callback: Callback) {
callback.resolve(mediaObserverMap[params["channelId"] as! String]) { it in
it.setMaxMetadataSize(params["size"] as! Int)
callback.resolve(mediaObserverMap[params["channelId"] as! String]) {
$0.setMaxMetadataSize(params["size"] as! Int)
}
}

@objc func sendMetadata(_ params: NSDictionary, _ callback: Callback) {
callback.resolve(mediaObserverMap[params["channelId"] as! String]) { it in
it.addMetadata(params["metadata"] as! String)
callback.resolve(mediaObserverMap[params["channelId"] as! String]) {
$0.addMetadata(params["metadata"] as! String)
}
}

Expand Down Expand Up @@ -356,7 +356,7 @@ class RtcChannelManager: NSObject, RtcChannelInterface {
if let it = self[params["channelId"] as! String] {
code = it.createDataStream(&streamId, reliable: params["reliable"] as! Bool, ordered: params["ordered"] as! Bool)
}
callback.code(code) { it in
callback.code(code) { ignore in
streamId
}
}
Expand Down
10 changes: 5 additions & 5 deletions ios/RCTAgora/Base/RtcChannelEvent.swift
Original file line number Diff line number Diff line change
Expand Up @@ -220,23 +220,23 @@ extension RtcChannelEventHandler: AgoraRtcChannelDelegate {
public func rtcChannel(_ rtcChannel: AgoraRtcChannel, didReceive event: AgoraChannelMediaRelayEvent) {
callback(RtcChannelEvents.ChannelMediaRelayEvent, rtcChannel, event.rawValue)
}

func rtcChannel(_ rtcChannel: AgoraRtcChannel, didAudioPublishStateChange oldState: AgoraStreamPublishState, newState: AgoraStreamPublishState, elapseSinceLastState: Int) {
callback(RtcChannelEvents.AudioPublishStateChanged, rtcChannel, rtcChannel.getId(), oldState.rawValue, newState.rawValue, elapseSinceLastState)
}

func rtcChannel(_ rtcChannel: AgoraRtcChannel, didVideoPublishStateChange oldState: AgoraStreamPublishState, newState: AgoraStreamPublishState, elapseSinceLastState: Int) {
callback(RtcChannelEvents.VideoPublishStateChanged, rtcChannel, rtcChannel.getId(), oldState.rawValue, newState.rawValue, elapseSinceLastState)
}

func rtcChannel(_ rtcChannel: AgoraRtcChannel, didAudioSubscribeStateChange uid: UInt, oldState: AgoraStreamSubscribeState, newState: AgoraStreamSubscribeState, elapseSinceLastState: Int) {
callback(RtcChannelEvents.AudioSubscribeStateChanged, rtcChannel, rtcChannel.getId(), uid, oldState.rawValue, newState.rawValue, elapseSinceLastState)
}

func rtcChannel(_ rtcChannel: AgoraRtcChannel, didVideoSubscribeStateChange uid: UInt, oldState: AgoraStreamSubscribeState, newState: AgoraStreamSubscribeState, elapseSinceLastState: Int) {
callback(RtcChannelEvents.VideoSubscribeStateChanged, rtcChannel, rtcChannel.getId(), uid, oldState.rawValue, newState.rawValue, elapseSinceLastState)
}

func rtcChannel(_ rtcChannel: AgoraRtcChannel, rtmpStreamingEventWithUrl url: String, eventCode: AgoraRtmpStreamingEvent) {
callback(RtcChannelEvents.RtmpStreamingEvent, rtcChannel, url, eventCode.rawValue)
}
Expand Down
Loading