Make pacmog no-alloc #49
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
|
Owner
|
Resolved in #52 . it should be noted that Rust 1.81 or later is required. Not yet published on crate.io (there is still some work to do). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As great as
anyhowis, it requires a global allocator. Since pacmog is targeted towards embedded systems, requiring alloc limits its adoption. Doing that for an error framework seems like an awkward tradeoff. This PR replacesanyhowwith embeded_error_chain which is no-std and no-alloc.Totally understand this is an unsolicited and somewhat large change. I need it for my use, so I'll maintain it on my own if I need to. Seemed like a reasonable speculative change though given pacmog's positioning.