Skip to content

DPL: improve message when driver client is not yet connected #5582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ktf merged 1 commit into from
Feb 28, 2021
Merged

DPL: improve message when driver client is not yet connected #5582

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
DPL: improve message when driver client is not yet connected
  • Loading branch information
@ktf
ktf authored Feb 28, 2021
commit bc60d9df0b47c580822e89263f3d0796717b7b8c
10 changes: 5 additions & 5 deletions Framework/Core/src/WSDriverClient.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,25 +98,25 @@ void WSDriverClient::flushPending()
static bool printed1 = false;
static bool printed2 = false;
if (!mClient) {
if (mBacklog.size() > 1000) {
if (mBacklog.size() > 2000) {
if (!printed1) {
LOG(WARNING) << "Unable to communicate with driver because client does not exist";
LOG(WARNING) << "Unable to communicate with driver because client does not exist. Continuing connection attempts.";
printed1 = true;
}
}
return;
}
if (!(mClient->isHandshaken())) {
if (mBacklog.size() > 1000) {
if (mBacklog.size() > 2000) {
if (!printed2) {
LOG(WARNING) << "Unable to communicate with driver because client is not connected";
LOG(WARNING) << "Unable to communicate with driver because client is not connected. Continuing connection attempts.";
printed2 = true;
}
}
return;
}
if (printed1 || printed2) {
LOGP(warning, "DriverClient connected successfully. Flushing message backlog of {} messages", mBacklog.size());
LOGP(warning, "DriverClient connected successfully. Flushing message backlog of {} messages. All is good.", mBacklog.size());
printed1 = false;
printed2 = false;
}
Expand Down