Skip to content

[QC-769] Desambiguify DS and Merger names #8660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ktf merged 4 commits into from
Apr 28, 2022
Merged

[QC-769] Desambiguify DS and Merger names #8660

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
54669c8
[QC-769] Add detector name to merger name
Barthelemy Apr 26, 2022
50e71ef
log an error if several policies share the same name
Barthelemy Apr 26, 2022
c0b377d
format
Barthelemy Apr 26, 2022
f1f0419
proper order in the name
Barthelemy Apr 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
log an error if several policies share the same name
  • Loading branch information
@Barthelemy
Barthelemy committed Apr 26, 2022
commit 50e71efc3c8d4c98931bf53ff017fdd7b37d691c
5 changes: 5 additions & 0 deletions Utilities/DataSampling/src/DataSampling.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,12 +57,17 @@ void DataSampling::GenerateInfrastructure(WorkflowSpec& workflow, const boost::p
void DataSampling::DoGenerateInfrastructure(Dispatcher& dispatcher, WorkflowSpec& workflow, const boost::property_tree::ptree& policiesTree, size_t threads, const std::string& host)
{
LOG(debug) << "Generating Data Sampling infrastructure...";
std::set<std::string> ids; // keep track of the ids we have met so far

for (auto&& policyConfig : policiesTree) {

// We don't want the Dispatcher to exit due to one faulty Policy
try {
auto policy = DataSamplingPolicy::fromConfiguration(policyConfig.second);
if(ids.count(policy.getName()) == 1) {
LOG(error) << "A policy with the same id has already been encountered (" + policy.getName() + ")";
}
ids.insert(policy.getName());
std::vector<std::string> machines;
if (policyConfig.second.count("machines") > 0) {
for (const auto& machine : policyConfig.second.get_child("machines")) {
Expand Down