Add option to specify the config file in basic workflow#189
Merged
Barthelemy merged 1 commit intoJun 18, 2019
Conversation
Collaborator
Author
|
This is needed by Adam for the demo tomorrow morning. thus I will force push it. Sorry. (it is the same as for the readout workflow). @knopers8 you can review it nevertheless as it is better to catch a problem later than never. |
Collaborator
|
It looks correct. |
knopers8
reviewed
Jun 19, 2019
| return specs; | ||
| } | ||
|
|
||
| // TODO merge this with the one from runReadout.cxx |
Collaborator
There was a problem hiding this comment.
I wouldn't sweat it, because when we use the workflow merging, in runBasic and runReadout we will have data producers only (nothing to configure) and the config files will need to be passed explicitly to o2-qc-run-qc
Collaborator
Author
There was a problem hiding this comment.
Ok, so I will not press this issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.