Skip to content

Conversation

@7sunarni
Copy link
Contributor

@7sunarni 7sunarni commented May 9, 2023

Why this

I want to config cleanup job image with values.yaml

@7sunarni
Copy link
Contributor Author

7sunarni commented May 9, 2023

@ringtail

@ringtail
Copy link
Member

@EnnnOK I am not sure about that. But I think it should be an optional choose for users.

@7sunarni
Copy link
Contributor Author

7sunarni commented May 10, 2023

@EnnnOK I am not sure about that. But I think it should be an optional choose for users.

@ringtail
Yes. If user use private docker registry, they must modify chart files when they want to remove CRDs because their environment can not get cleanup image. If we config cleanup image in values.yaml, they don't need to modify chart, just pass helm config parameter.

@ringtail
Copy link
Member

/LGTM

@ringtail ringtail merged commit 42ed25d into AliyunContainerService:master May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants