Fix/problem decorator #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alpha018
added
bug
…husky setup Update the npm script from `postinstall` to `prepare` in `package.json` to ensure husky hooks trigger correctly. Use `|| exit 0` to avoid errors during execution when husky is not present.
Refactor the existing `setClaims` endpoint to `setRoleClaims` to distinguish between generic claims and role-based claims. Introduce a new `setClaims` endpoint for setting generic claims. Add corresponding get endpoints for retrieving both roles and claims, enhancing clarity in API usage. docs(README): update documentation with new role claims functionality Update the README to reflect changes in API calls such as `setClaimsRoleBase` and details for handling custom claims with `rolesClaimKey`. Clarify examples provided for role-based access control to match the updated function signatures. test(app-local-validation.e2e-spec.ts): enhance e2e tests with local environment variable support Introduce `FIREBASE_TEST_USER_LOCAL` environment variable for improved test isolation. Add additional test cases for new set and get claims functions to ensure comprehensive coverage. fix(firebase.guard): refactor token verification and role handling logic Improve token verification by abstracting logic into `verifyToken` for cleaner error handling. Refactor role validation to a dedicated method `handleRoleValidation` to modularize complex logic and improve maintainability. miscellaneous: - Add mock for custom claims to support testing scenarios. - Update the FirebaseProvider to handle different keys for roles, supporting flexible claim structures.
Update the method to retrieve decoded ID token and role claims using `@FirebaseUser` and `@FirebaseRolesClaims` decorators. Remove outdated example in `README.md`. Add documentation for `FirebaseRolesClaims` decorator and mark `FirebaseUserClaims` as deprecated in code comments. This change enhances clarity and simplifies role claims extraction for users.
Alpha018
force-pushed
the
fix/problem-decorator
branch
from
f972ebc to
135cc13
Compare
Owner
Author
|
🎉 This PR is included in version 1.8.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.