MSRV-based Cleanup #85
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james7132
force-pushed
the
cleanup
branch
2 times, most recently
from
760ccaa to
58f9dae
Compare
Amanieu
reviewed
Aug 19, 2025
| @@ -0,0 +1,24 @@ | |||
| [package] | |||
| name = "benches" | |||
Owner
There was a problem hiding this comment.
Can you explain why a separate package is necessary here?
Contributor
Author
There was a problem hiding this comment.
It lets us bump the version of criterion without bumping the MSRV.
Amanieu
reviewed
Aug 19, 2025
Co-authored-by: Amanieu d'Antras <[email protected]>
Amanieu
reviewed
Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does not modify the existing MSRV, but cleans up items that otherwise have been introduced before it.
I've also added a CI task for explicitly testing against the MSRV since the current job does not match it at Rust 1.74.