Skip to content

refactor: Move React SDK to this repo and consolidate Javascript SDK packages to depend on local versions of each other #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

refactor: Move React SDK to this repo and consolidate Javascript SDK packages to depend on local versions of each other #1

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
838856f
packages accessed locally
Aug 3, 2020
7016282
pkgs references changed to relative path
Aug 4, 2020
1d4a91e
added react sdk as sub module
Aug 4, 2020
6269252
Added relative path in pkgs also
Aug 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/optimizely-sdk/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,10 @@
},
"homepage": "https://github.com/optimizely/javascript-sdk/tree/master/packages/optimizely-sdk",
"dependencies": {
"@optimizely/js-sdk-datafile-manager": "^0.7.0",
"@optimizely/js-sdk-event-processor": "^0.6.0",
"@optimizely/js-sdk-logging": "^0.1.0",
"@optimizely/js-sdk-utils": "^0.4.0",
"@optimizely/js-sdk-datafile-manager": "file:../datafile-manager/optimizely-js-sdk-datafile-manager-0.7.0.tgz",
"@optimizely/js-sdk-event-processor": "file:../event-processor/optimizely-js-sdk-event-processor-0.6.0.tgz",
"@optimizely/js-sdk-logging": "file:../logging/optimizely-js-sdk-logging-0.1.0.tgz",
"@optimizely/js-sdk-utils": "file:../utils/optimizely-js-sdk-utils-0.4.0.tgz",
Copy link
Collaborator Author

@zashraf1985 zashraf1985 Aug 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we reference the folders instead of adding packed archives.

"json-schema": "^0.2.3",
"murmurhash": "0.0.2"
},
Expand Down