[bug] Format date values with expected format #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Date values are expected to be in ISO 8601 format (YYYY-MM-DD) but value returned can be off on single digit days and months
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Date values are displayed in ISO 8601 format (YYYY-MM-DD) but value returned can be formatted differently for single digit days or months.
For example, if you have a date field with a value of 2023-01-09, the value returned will be 2023-1-9.
Because whole numbers are passed into arguments of the function
clickDayand then concatenated into a string, the leading zeros are dropped.This PR adds passes the final values into the dayjs formatter to ensure that the date is formatted correctly.